Skip to content

Commit d2898f8

Browse files
committed
fix: reuse existing schemas for the output
1 parent 0224415 commit d2898f8

2 files changed

Lines changed: 11 additions & 16 deletions

File tree

evaluation_function/evaluation.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
ParseResult,
2020
SectionFeedback,
2121
SpaceComplexityResult,
22-
TestCaseFeedback,
22+
# TestCaseFeedback,
2323
TestCaseResult,
2424
TimeComplexityResult,
2525
)
@@ -424,14 +424,14 @@ def _generate_feedback(
424424
# )
425425

426426
# Test cases section
427-
test_case_feedback = [
428-
TestCaseFeedback(
429-
index=i + 1,
430-
passed=tc.passed,
431-
error_message=tc.error_message if tc.error_message else ""
432-
)
433-
for i, tc in enumerate(test_case_results)
434-
] if test_case_results else []
427+
# test_case_feedback = [
428+
# TestCaseFeedback(
429+
# index=i + 1,
430+
# passed=tc.passed,
431+
# error_message=tc.error_message if tc.error_message else ""
432+
# )
433+
# for i, tc in enumerate(test_case_results)
434+
# ] if test_case_results else []
435435

436436
# Detailed sections
437437
detailed_sections = [
@@ -448,6 +448,6 @@ def _generate_feedback(
448448
overall_message=overall_message,
449449
time_complexity=time_result,
450450
space_complexity=space_result,
451-
test_cases=test_case_feedback,
451+
test_cases=test_case_results,
452452
detailed_sections=detailed_sections
453453
)

evaluation_function/schemas/output_schema.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,6 @@ class ComplexityAnalysis(BaseModel):
194194
from typing import List, Optional
195195

196196

197-
class TestCaseFeedback(BaseModel):
198-
index: int
199-
passed: bool
200-
error_message: str = Field(default="")
201-
202197

203198
class SectionFeedback(BaseModel):
204199
importance: str
@@ -211,5 +206,5 @@ class EvaluationResult(BaseModel):
211206
overall_message: str
212207
time_complexity: Optional[TimeComplexityResult] = Field(default=None)
213208
space_complexity: Optional[SpaceComplexityResult] = Field(default=None)
214-
test_cases: List[TestCaseFeedback] = Field(default_factory=list)
209+
test_cases: List[TestCaseResult] = Field(default_factory=list)
215210
detailed_sections: List[SectionFeedback] = Field(default_factory=list)

0 commit comments

Comments
 (0)