feat: evalaution defaults to isomorphism when and answer graph is provided

Author: HarrySu123

evaluation_function/evaluation.py

@@ -631,11 +631,12 @@ def _err(msg: str) -> Result:
     try:
         p = EvaluationParams.model_validate(raw_params)
     except ValidationError as e:
-        return _err(
-            "Invalid params schema. Expected e.g. "
-            "{'evaluation_type': 'connectivity'|'bipartite'|'graph_coloring'|...}. "
-            f"Error: {e}"
-        )
+        if ans.graph is None:
+            return _err(
+                "Invalid params schema. Expected e.g. "
+                "{'evaluation_type': 'connectivity'|'bipartite'|'graph_coloring'|...}. "
+                f"Error: {e}"
+            )
 
     # ── resolve graphs ───────────────────────────────────────────────────
     # student_graph (resp.graph) is always present — the student submits a graph.
@@ -889,6 +890,11 @@ def _eval_clique_number() -> Result:
         "clique_number": _eval_clique_number,
     }
 
+    # If answer graph is provided, run isomorphism check regardless of params
+    if ans.graph is not None:
+        return _eval_isomorphism()
+    
+    # Otherwise use the evaluation type from params
     handler = dispatch.get(p.evaluation_type)
     if handler is None:
         return _err(f"Unsupported evaluation_type: '{p.evaluation_type}'.")

poetry.lock

@@ -481,30 +481,35 @@ def test_wrong_sequence(self):
 
 # ── SUBGRAPH ─────────────────────────────────────────────────────────────
 
-class TestSubgraph:
-    def test_is_subgraph(self):
-        parent = _graph(["A", "B", "C"], [
-            {"source": "A", "target": "B"}, {"source": "B", "target": "C"}, {"source": "C", "target": "A"}
-        ])
-        sub = _graph(["A", "B"], [{"source": "A", "target": "B"}])
-        r = _eval({"graph": sub}, {"graph": parent}, {"evaluation_type": "subgraph"})
-        assert r["is_correct"] is True
-
-    def test_not_subgraph(self):
-        parent = _graph(["A", "B", "C"], [
-            {"source": "A", "target": "B"}, {"source": "B", "target": "C"}
-        ])
-        sub = _graph(["A", "C"], [{"source": "A", "target": "C"}])
-        r = _eval({"graph": sub}, {"graph": parent}, {"evaluation_type": "subgraph"})
-        assert r["is_correct"] is False
-
-    def test_missing_teacher_graph(self):
-        r = _eval({"graph": _graph(["A"], [])}, {}, {"evaluation_type": "subgraph"})
-        assert r["is_correct"] is False
-
-    def test_missing_student_graph(self):
-        r = _eval({}, {"graph": _graph(["A"], [])}, {"evaluation_type": "subgraph"})
-        assert r["is_correct"] is False
+# NOTE: Subgraph tests removed because the design specifies:
+# "If answer.graph is provided, always run isomorphism (regardless of evaluation_type)"
+# Since subgraph checking requires answer.graph (the parent), it conflicts with this design.
+# Subgraph functionality would need a different API design to work (e.g., separate field for parent graph)
+
+# class TestSubgraph:
+#     def test_is_subgraph(self):
+#         parent = _graph(["A", "B", "C"], [
+#             {"source": "A", "target": "B"}, {"source": "B", "target": "C"}, {"source": "C", "target": "A"}
+#         ])
+#         sub = _graph(["A", "B"], [{"source": "A", "target": "B"}])
+#         r = _eval({"graph": sub}, {"graph": parent}, {"evaluation_type": "subgraph"})
+#         assert r["is_correct"] is True
+#
+#     def test_not_subgraph(self):
+#         parent = _graph(["A", "B", "C"], [
+#             {"source": "A", "target": "B"}, {"source": "B", "target": "C"}
+#         ])
+#         sub = _graph(["A", "C"], [{"source": "A", "target": "C"}])
+#         r = _eval({"graph": sub}, {"graph": parent}, {"evaluation_type": "subgraph"})
+#         assert r["is_correct"] is False
+#
+#     def test_missing_teacher_graph(self):
+#         r = _eval({"graph": _graph(["A"], [])}, {}, {"evaluation_type": "subgraph"})
+#         assert r["is_correct"] is False
+#
+#     def test_missing_student_graph(self):
+#         r = _eval({}, {"graph": _graph(["A"], [])}, {"evaluation_type": "subgraph"})
+#         assert r["is_correct"] is False
 
 
 # ── HAMILTONIAN PATH ─────────────────────────────────────────────────────