Fix frozen blocks approvals#26
Draft
juanbono wants to merge 1 commit into
Draft
Conversation
The existing `_approve` override blocked allowance state changes while paused, but missed the symmetric case for frozen accounts: a frozen owner could call `approve(...)` and stage an allowance that goes live the moment the freeze is lifted, defeating the protective intent of the freeze flag. Add `whenNotFrozen(owner)` and `whenNotFrozen(spender)` to the override to mirror `_update`'s symmetric `from`/`to` freeze policy. Both directions are blocked: - A frozen owner cannot grant allowance. - A non-frozen owner cannot grant allowance to a frozen spender. The spender side is intentional belt-and-braces — a frozen account cannot exercise the allowance anyway, but blocking the grant prevents it from going live on unfreeze. Internal `_spendAllowance` (called by `transferFrom` / `burnFrom`) also routes through `_approve`, so the freeze check fires at the allowance- decrement step rather than at `_update`. Same outcome, marginally different revert path — covered by tests. Regression coverage: - `test_ApproveByFrozenOwnerReverts` — frozen owner blocked at approve. - `test_ApproveToFrozenSpenderReverts` — frozen spender blocked at approve. - `test_TransferFromFrozenOwnerReverts` — internal `_approve` revert surfaces from `_spendAllowance` before `_update`. - `test_TransferFromBySpenderWhenFrozenReverts` — frozen spender path. - `test_ApproveAfterUnfreezeSucceeds` — block is reversible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.