Merge branch 'main' into fix-test-seq

Author: joannecheng

CHANGELOG.md

@@ -5,6 +5,7 @@
 ## Fixed
 
 - Fix beholder watch functionality that would cause a NullPointerException earlier.
+- Resolve reflective calls in profiling plugin.
 - Fix `kaocha.testable/test-seq` not respecting `:kaocha.testable/skip` on root testable
 - Fix `kaocha.testable/test-seq-with-skipped` omitting skipped tests on nested testables
 

README.md

@@ -24,7 +24,7 @@ Jump to [Quick start](#quick-start) | [Docs](#docs)
 - to observe and study
 - on-the-spot investigation
 
-See the [Line Dict entry](https://dict.naver.com/linedict/zhendict/dict.html#/cnen/entry/89b3f694bb3a4fd49e3241c6bd1cb79f) for an audio sample.
+See the [Hanzii entry](https://hanzii.net/search/word/%E8%80%83%E5%AF%9F) for an audio sample.
 
 
 ## Need help?

src/kaocha/plugin/profiling.clj

@@ -7,6 +7,8 @@
   (:import java.time.Instant
            java.time.temporal.ChronoUnit))
 
+(set! *warn-on-reflection* true)
+
 (spec/def ::start #(instance? Instant %))
 (spec/def ::duration nat-int?)
 (spec/def ::profiling? boolean?)
@@ -18,7 +20,7 @@
 (defn stop [testable]
   (cond-> testable
     (::start testable)
-    (assoc ::duration (.until (::start testable)
+    (assoc ::duration (.until ^Instant (::start testable)
                               (Instant/now)
                               ChronoUnit/NANOS))))
 

test/features/plugins/orchestra_plugin.feature

@@ -45,7 +45,7 @@ Feature: Orchestra (spec instrumentation)
     """
     ERROR in orchestra-test/spec-fail-test (orchestra_test.clj:11)
     Just testing simple-fn
-    Call to orchestra-test/simple-fn did not conform to spec.
+    Call to #'orchestra-test/simple-fn did not conform to spec.
     orchestra_test.clj:11
 
     -- Spec failed --------------------

tests.edn

@@ -1,23 +1,24 @@
 #kaocha/v1
-{:plugins [:kaocha.plugin.alpha/info
-           :profiling
-           :print-invocations
-           :hooks
-           :notifier
-           :kaocha.plugin/version-filter]
+ {:plugins [:kaocha.plugin.alpha/info
+            :profiling
+            :print-invocations
+            :hooks
+            :notifier
+            :kaocha.plugin/version-filter]
 
- :tests [{:id         :unit
-          :test-paths ["test/shared"
-                       "test/unit"]}
-         {:id                  :integration
-          :type                :kaocha.type/cucumber
-          :test-paths          ["test/shared"
-                                "test/features"]
-          :cucumber/glue-paths ["test/step_definitions"]}]
+  :tests [{:id         :unit
+           :test-paths ["test/shared"
+                        "test/unit"]}
+          {:id                  :integration
+           :type                :kaocha.type/cucumber
+           :test-paths          ["test/shared"
+                                 "test/features"]
+           :cucumber/glue-paths ["test/step_definitions"]
+           :kaocha.filter/skip [plugins.notifier-plugin/enabling-desktop-notifications]}]
 
- :kaocha.hooks/pre-load [kaocha.assertions/load-assertions]
+  :kaocha.hooks/pre-load [kaocha.assertions/load-assertions]
 
- :kaocha/bindings {kaocha.stacktrace/*stacktrace-filters* []
-                   kaocha.stacktrace/*stacktrace-stop-list* []}
+  :kaocha/bindings {kaocha.stacktrace/*stacktrace-filters* []
+                    kaocha.stacktrace/*stacktrace-stop-list* []}
 
- :reporter kaocha.report/documentation}
+  :reporter kaocha.report/documentation}