Update pronunciation link on README.md#463
Merged
Merged
Conversation
Unfortunately, seems like linedict is no more, and the thing that replaced it doesn't seem to have pronunciation for 考察 (although it seems to be very happy to give five different pronunciations for the English translation "nose around"). Hanzii.net appears to be maintained, and has a nicer pronunciation (imo) than Forvo's Mandarin one. And Pleco is unfortunately still mobile only.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 52 52
Lines 2819 2819
Branches 286 286
=======================================
Hits 2100 2100
Misses 523 523
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
thank you! |
github-project-automation
Bot
moved this from 🏃Quick Fixes
to ✅ Done
in Lambda Island Open Source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, seems like linedict is no more, and the thing that replaced it doesn't seem to have pronunciation for 考察 (although it seems to be very happy to give five different pronunciations for the English translation "nose around").
Hanzii.net appears to be maintained, and has a nicer pronunciation (imo) than Forvo's Mandarin one. And Pleco is unfortunately still mobile only.