address comment

Author: leiyuou

crates/lance-graph/src/parameter_substitution.rs

@@ -106,10 +106,13 @@ fn substitute_in_property_value(
     parameters: &HashMap<String, serde_json::Value>,
 ) -> Result<()> {
     if let PropertyValue::Parameter(name) = value {
-        let param_value = parameters.get(name).ok_or_else(|| GraphError::PlanError {
-            message: format!("Missing parameter: ${}", name),
-            location: snafu::Location::new(file!(), line!(), column!()),
-        })?;
+        let param_value =
+            parameters
+                .get(&name.to_lowercase())
+                .ok_or_else(|| GraphError::PlanError {
+                    message: format!("Missing parameter: ${}", name),
+                    location: snafu::Location::new(file!(), line!(), column!()),
+                })?;
 
         *value = json_to_property_value(param_value)?;
     }
@@ -198,10 +201,13 @@ fn substitute_in_value_expression(
 ) -> Result<()> {
     match expr {
         ValueExpression::Parameter(name) => {
-            let param_value = parameters.get(name).ok_or_else(|| GraphError::PlanError {
-                message: format!("Missing parameter: ${}", name),
-                location: snafu::Location::new(file!(), line!(), column!()),
-            })?;
+            let param_value =
+                parameters
+                    .get(&name.to_lowercase())
+                    .ok_or_else(|| GraphError::PlanError {
+                        message: format!("Missing parameter: ${}", name),
+                        location: snafu::Location::new(file!(), line!(), column!()),
+                    })?;
 
             // Check for array to VectorLiteral conversion
             if let serde_json::Value::Array(arr) = param_value {
@@ -257,7 +263,10 @@ fn json_to_property_value(value: &serde_json::Value) -> Result<PropertyValue> {
             } else if let Some(f) = n.as_f64() {
                 Ok(PropertyValue::Float(f))
             } else {
-                Ok(PropertyValue::Null)
+                Err(GraphError::PlanError {
+                    message: format!("Number parameter could not be converted to i64 or f64: {}", n),
+                    location: snafu::Location::new(file!(), line!(), column!()),
+                })
             }
         }
         serde_json::Value::String(s) => Ok(PropertyValue::String(s.clone())),

crates/lance-graph/src/query.rs

@@ -101,13 +101,16 @@ impl CypherQuery {
         K: Into<String>,
         V: Into<serde_json::Value>,
     {
-        self.parameters.insert(key.into(), value.into());
+        self.parameters
+            .insert(key.into().to_lowercase(), value.into());
         self
     }
 
     /// Add multiple parameters to the query
     pub fn with_parameters(mut self, params: HashMap<String, serde_json::Value>) -> Self {
-        self.parameters.extend(params);
+        for (k, v) in params {
+            self.parameters.insert(k.to_lowercase(), v);
+        }
         self
     }
 
@@ -1498,8 +1501,8 @@ mod tests {
         .unwrap()
         .with_parameters(params);
 
-        assert!(query.parameters().contains_key("minAge"));
-        assert!(query.parameters().contains_key("maxAge"));
+        assert!(query.parameters().contains_key("minage"));
+        assert!(query.parameters().contains_key("maxage"));
     }
 
     #[test]