Skip to content

feat: support variable-length queries in the datafusion planner#24

Merged
beinan merged 3 commits into
lance-format:mainfrom
ChunxuTang:var-length
Oct 31, 2025
Merged

feat: support variable-length queries in the datafusion planner#24
beinan merged 3 commits into
lance-format:mainfrom
ChunxuTang:var-length

Conversation

@ChunxuTang

Copy link
Copy Markdown
Collaborator

This PR

  • adds the support of variable-length queries in the datafusion planner, with a unrolling strategy, similar to the current dataframe-based approach used by the execute method.
  • adds integration tests of variable-length queries
  • fixs some bugs in the datafusion planner, such as correctly passing down target properties in single-hop expands

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.52221% with 125 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@40f3b9a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
rust/lance-graph/src/datafusion_planner.rs 89.46% 125 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   78.62%           
=======================================
  Files           ?       16           
  Lines           ?     6483           
  Branches        ?        0           
=======================================
  Hits            ?     5097           
  Misses          ?     1386           
  Partials        ?        0           
Flag Coverage Δ
rust-unittests 78.62% <89.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beinan beinan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beinan beinan merged commit f8e6f9a into lance-format:main Oct 31, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the var-length branch November 3, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants