Skip to content

refactor: refactor the datafusion planner#37

Merged
beinan merged 1 commit into
lance-format:mainfrom
ChunxuTang:refactor
Nov 8, 2025
Merged

refactor: refactor the datafusion planner#37
beinan merged 1 commit into
lance-format:mainfrom
ChunxuTang:refactor

Conversation

@ChunxuTang

Copy link
Copy Markdown
Collaborator

This PR refactors the datafusion planner into multiple files:

  • mod.rs
  • analysis.rs: query analysis phase
  • builder.rs: datafusion plan building phase
  • config_helpers.rs: shared utilities
  • expression.rs: convert to datafusion Expr objs
  • join_ops.rs: assemble relationship joins
  • scan_ops.rs: constructs node/relationship scans
  • test_fixtures.rs: shared test utilities

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.28645% with 210 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@d843b4b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ust/lance-graph/src/datafusion_planner/scan_ops.rs 82.44% 66 Missing ⚠️
rust/lance-graph/src/datafusion_planner/builder.rs 95.79% 53 Missing ⚠️
...t/lance-graph/src/datafusion_planner/expression.rs 93.20% 32 Missing ⚠️
...ust/lance-graph/src/datafusion_planner/join_ops.rs 92.91% 28 Missing ⚠️
rust/lance-graph/src/datafusion_planner/mod.rs 88.48% 19 Missing ⚠️
...ust/lance-graph/src/datafusion_planner/analysis.rs 97.66% 6 Missing ⚠️
...nce-graph/src/datafusion_planner/config_helpers.rs 96.40% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage        ?   81.68%           
=======================================
  Files           ?       23           
  Lines           ?     7846           
  Branches        ?        0           
=======================================
  Hits            ?     6409           
  Misses          ?     1437           
  Partials        ?        0           
Flag Coverage Δ
rust-unittests 81.68% <93.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beinan beinan merged commit c27809a into lance-format:main Nov 8, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the refactor branch November 16, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants