Skip to content

feat: implement AVG aggregation of the datafusion planner#42

Merged
beinan merged 2 commits into
lance-format:mainfrom
ChunxuTang:avg
Nov 12, 2025
Merged

feat: implement AVG aggregation of the datafusion planner#42
beinan merged 2 commits into
lance-format:mainfrom
ChunxuTang:avg

Conversation

@ChunxuTang

Copy link
Copy Markdown
Collaborator

This PR:

  • adds the support of AVG (AVERAGE) aggregation function of the datafusion planner
  • adds the validation of properties of SUM/AVG/MIN/MAX (e.g. SUM(p.name)) in the semantic analysis, so we don't need to rehandle the illegal cases in the datafusion planner

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7625f3d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
rust/lance-graph/src/semantic.rs 89.90% 11 Missing ⚠️
...t/lance-graph/src/datafusion_planner/expression.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage        ?   81.93%           
=======================================
  Files           ?       23           
  Lines           ?     8532           
  Branches        ?        0           
=======================================
  Hits            ?     6991           
  Misses          ?     1541           
  Partials        ?        0           
Flag Coverage Δ
rust-unittests 81.93% <90.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beinan beinan merged commit 7505dad into lance-format:main Nov 12, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the avg branch November 16, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants