Skip to content

feat: Use datafusion planner as the default execution strategy#53

Merged
beinan merged 1 commit into
lance-format:mainfrom
ChunxuTang:execute
Dec 3, 2025
Merged

feat: Use datafusion planner as the default execution strategy#53
beinan merged 1 commit into
lance-format:mainfrom
ChunxuTang:execute

Conversation

@ChunxuTang

Copy link
Copy Markdown
Collaborator

This PR

  • uses the datafusion planner as the default execution strategy in the execute API
  • moves the previous implementation of the execute to execute_simple
  • updates the Python api accordingly
  • refactors some helper methods of the previous execute method to simple_executor.rs
  • removes dead code in the qeury.rs

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@ChunxuTang ChunxuTang requested a review from beinan December 3, 2025 21:12
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.55056% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-graph/src/query/simple_executor.rs 59.70% 27 Missing ⚠️
rust/lance-graph/src/query.rs 59.09% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@beinan beinan merged commit 2e0bcae into lance-format:main Dec 3, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the execute branch December 27, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants