spec: use dedicated response for DML operations

Author: jackye1995

java/lance-namespace-adapter/src/main/java/com/lancedb/lance/namespace/adapter/ClientToServerResponse.java

@@ -13,6 +13,8 @@
  */
 package com.lancedb.lance.namespace.adapter;
 
+import com.lancedb.lance.namespace.server.springboot.model.CreateNamespaceResponse;
+import com.lancedb.lance.namespace.server.springboot.model.DropNamespaceResponse;
 import com.lancedb.lance.namespace.server.springboot.model.GetNamespaceResponse;
 import com.lancedb.lance.namespace.server.springboot.model.GetTableResponse;
 import com.lancedb.lance.namespace.server.springboot.model.ListNamespacesResponse;
@@ -38,6 +40,24 @@ public static ListNamespacesResponse listNamespaces(
     return converted;
   }
 
+  public static CreateNamespaceResponse createNamespace(
+      com.lancedb.lance.namespace.client.apache.model.CreateNamespaceResponse response) {
+    CreateNamespaceResponse converted = new CreateNamespaceResponse();
+    converted.setParent(response.getParent());
+    converted.setProperties(response.getProperties());
+    converted.setName(response.getName());
+    return converted;
+  }
+
+  public static DropNamespaceResponse dropNamespace(
+      com.lancedb.lance.namespace.client.apache.model.DropNamespaceResponse response) {
+    DropNamespaceResponse converted = new DropNamespaceResponse();
+    converted.setParent(response.getParent());
+    converted.setProperties(response.getProperties());
+    converted.setName(response.getName());
+    return converted;
+  }
+
   public static NamespaceExistsResponse namespaceExists(
       com.lancedb.lance.namespace.client.apache.model.NamespaceExistsResponse response) {
     NamespaceExistsResponse converted = new NamespaceExistsResponse();

java/lance-namespace-adapter/src/main/java/com/lancedb/lance/namespace/adapter/NamespaceController.java

@@ -16,7 +16,9 @@
 import com.lancedb.lance.namespace.client.LanceNamespace;
 import com.lancedb.lance.namespace.server.springboot.api.NamespaceApi;
 import com.lancedb.lance.namespace.server.springboot.model.CreateNamespaceRequest;
+import com.lancedb.lance.namespace.server.springboot.model.CreateNamespaceResponse;
 import com.lancedb.lance.namespace.server.springboot.model.DropNamespaceRequest;
+import com.lancedb.lance.namespace.server.springboot.model.DropNamespaceResponse;
 import com.lancedb.lance.namespace.server.springboot.model.GetNamespaceRequest;
 import com.lancedb.lance.namespace.server.springboot.model.GetNamespaceResponse;
 import com.lancedb.lance.namespace.server.springboot.model.ListNamespacesRequest;
@@ -37,18 +39,20 @@ public NamespaceController(LanceNamespace delegate) {
   }
 
   @Override
-  public ResponseEntity<GetNamespaceResponse> createNamespace(
+  public ResponseEntity<CreateNamespaceResponse> createNamespace(
       CreateNamespaceRequest createNamespaceRequest) {
     return ResponseEntity.ok(
-        ClientToServerResponse.getNamespace(
+        ClientToServerResponse.createNamespace(
             delegate.createNamespace(
                 ServerToClientRequest.createNamespace(createNamespaceRequest))));
   }
 
   @Override
-  public ResponseEntity<Object> dropNamespace(DropNamespaceRequest dropNamespaceRequest) {
-    delegate.dropNamespace(ServerToClientRequest.dropNamespace(dropNamespaceRequest));
-    return ResponseEntity.ok().build();
+  public ResponseEntity<DropNamespaceResponse> dropNamespace(
+      DropNamespaceRequest dropNamespaceRequest) {
+    return ResponseEntity.ok(
+        ClientToServerResponse.dropNamespace(
+            delegate.dropNamespace(ServerToClientRequest.dropNamespace(dropNamespaceRequest))));
   }
 
   @Override

java/lance-namespace-apache-client/.openapi-generator/FILES

@@ -2,7 +2,9 @@
 README.md
 api/openapi.yaml
 docs/CreateNamespaceRequest.md
+docs/CreateNamespaceResponse.md
 docs/DropNamespaceRequest.md
+docs/DropNamespaceResponse.md
 docs/ErrorResponse.md
 docs/GetNamespaceRequest.md
 docs/GetNamespaceResponse.md
@@ -37,7 +39,9 @@ src/main/java/com/lancedb/lance/namespace/client/apache/auth/Authentication.java
 src/main/java/com/lancedb/lance/namespace/client/apache/auth/HttpBasicAuth.java
 src/main/java/com/lancedb/lance/namespace/client/apache/auth/HttpBearerAuth.java
 src/main/java/com/lancedb/lance/namespace/client/apache/model/CreateNamespaceRequest.java
+src/main/java/com/lancedb/lance/namespace/client/apache/model/CreateNamespaceResponse.java
 src/main/java/com/lancedb/lance/namespace/client/apache/model/DropNamespaceRequest.java
+src/main/java/com/lancedb/lance/namespace/client/apache/model/DropNamespaceResponse.java
 src/main/java/com/lancedb/lance/namespace/client/apache/model/ErrorResponse.java
 src/main/java/com/lancedb/lance/namespace/client/apache/model/GetNamespaceRequest.java
 src/main/java/com/lancedb/lance/namespace/client/apache/model/GetNamespaceResponse.java

java/lance-namespace-apache-client/README.md

@@ -91,7 +91,7 @@ public class NamespaceApiExample {
         NamespaceApi apiInstance = new NamespaceApi(defaultClient);
         CreateNamespaceRequest createNamespaceRequest = new CreateNamespaceRequest(); // CreateNamespaceRequest | 
         try {
-            GetNamespaceResponse result = apiInstance.createNamespace(createNamespaceRequest);
+            CreateNamespaceResponse result = apiInstance.createNamespace(createNamespaceRequest);
             System.out.println(result);
         } catch (ApiException e) {
             System.err.println("Exception when calling NamespaceApi#createNamespace");
@@ -124,7 +124,9 @@ Class | Method | HTTP request | Description
 ## Documentation for Models
 
  - [CreateNamespaceRequest](docs/CreateNamespaceRequest.md)
+ - [CreateNamespaceResponse](docs/CreateNamespaceResponse.md)
  - [DropNamespaceRequest](docs/DropNamespaceRequest.md)
+ - [DropNamespaceResponse](docs/DropNamespaceResponse.md)
  - [ErrorResponse](docs/ErrorResponse.md)
  - [GetNamespaceRequest](docs/GetNamespaceRequest.md)
  - [GetNamespaceResponse](docs/GetNamespaceResponse.md)

java/lance-namespace-apache-client/api/openapi.yaml

@@ -52,7 +52,7 @@ paths:
         required: true
       responses:
         "200":
-          $ref: '#/components/responses/GetNamespaceResponse'
+          $ref: '#/components/responses/CreateNamespaceResponse'
         "400":
           $ref: '#/components/responses/BadRequestErrorResponse'
         "401":
@@ -333,6 +333,12 @@ components:
             $ref: '#/components/schemas/GetNamespaceResponse'
       description: "Returns a namespace, as well as any properties stored on the namespace\
         \ if namespace properties are supported by the server."
+    CreateNamespaceResponse:
+      content:
+        application/json:
+          schema:
+            $ref: '#/components/schemas/CreateNamespaceResponse'
+      description: Result of creating a namespace
     DropNamespaceResponse:
       content:
         application/json:
@@ -531,6 +537,26 @@ components:
       required:
       - mode
       - name
+    CreateNamespaceResponse:
+      example:
+        parent:
+        - parent
+        - parent
+        name: name
+        properties:
+          key: properties
+      properties:
+        name:
+          type: string
+        parent:
+          items:
+            type: string
+          type: array
+        properties:
+          additionalProperties:
+            type: string
+      required:
+      - name
     ListNamespacesRequest:
       example:
         parent:
@@ -640,7 +666,23 @@ components:
       required:
       - name
     DropNamespaceResponse:
-      type: object
+      example:
+        parent:
+        - parent
+        - parent
+        name: name
+        properties:
+          key: properties
+      properties:
+        name:
+          type: string
+        parent:
+          items:
+            type: string
+          type: array
+        properties:
+          additionalProperties:
+            type: string
     NamespaceExistsRequest:
       example:
         parent:

java/lance-namespace-apache-client/docs/CreateNamespaceResponse.md

@@ -0,0 +1,15 @@
+
+
+# CreateNamespaceResponse
+
+
+## Properties
+
+| Name | Type | Description | Notes |
+|------------ | ------------- | ------------- | -------------|
+|**name** | **String** |  |  |
+|**parent** | **List<String>** |  |  [optional] |
+|**properties** | **Map<String, String>** |  |  [optional] |
+
+
+

java/lance-namespace-apache-client/docs/DropNamespaceResponse.md

@@ -0,0 +1,15 @@
+
+
+# DropNamespaceResponse
+
+
+## Properties
+
+| Name | Type | Description | Notes |
+|------------ | ------------- | ------------- | -------------|
+|**name** | **String** |  |  [optional] |
+|**parent** | **List<String>** |  |  [optional] |
+|**properties** | **Map<String, String>** |  |  [optional] |
+
+
+

java/lance-namespace-apache-client/docs/NamespaceApi.md

@@ -14,7 +14,7 @@ All URIs are relative to *http://localhost:2333*
 
 ## createNamespace
 
-> GetNamespaceResponse createNamespace(createNamespaceRequest)
+> CreateNamespaceResponse createNamespace(createNamespaceRequest)
 
 Create a new namespace
 
@@ -38,7 +38,7 @@ public class Example {
         NamespaceApi apiInstance = new NamespaceApi(defaultClient);
         CreateNamespaceRequest createNamespaceRequest = new CreateNamespaceRequest(); // CreateNamespaceRequest | 
         try {
-            GetNamespaceResponse result = apiInstance.createNamespace(createNamespaceRequest);
+            CreateNamespaceResponse result = apiInstance.createNamespace(createNamespaceRequest);
             System.out.println(result);
         } catch (ApiException e) {
             System.err.println("Exception when calling NamespaceApi#createNamespace");
@@ -60,7 +60,7 @@ public class Example {
 
 ### Return type
 
-[**GetNamespaceResponse**](GetNamespaceResponse.md)
+[**CreateNamespaceResponse**](CreateNamespaceResponse.md)
 
 ### Authorization
 
@@ -75,7 +75,7 @@ No authorization required
 ### HTTP response details
 | Status code | Description | Response headers |
 |-------------|-------------|------------------|
-| **200** | Returns a namespace, as well as any properties stored on the namespace if namespace properties are supported by the server. |  -  |
+| **200** | Result of creating a namespace |  -  |
 | **400** | Indicates a bad request error. It could be caused by an unexpected request body format or other forms of request validation failure, such as invalid json. Usually serves application/json content, although in some cases simple text/plain content might be returned by the server's middleware. |  -  |
 | **401** | Unauthorized. The request lacks valid authentication credentials for the operation. |  -  |
 | **403** | Forbidden. Authenticated user does not have the necessary permissions. |  -  |
@@ -87,7 +87,7 @@ No authorization required
 
 ## dropNamespace
 
-> Object dropNamespace(dropNamespaceRequest)
+> DropNamespaceResponse dropNamespace(dropNamespaceRequest)
 
 Drop a namespace
 
@@ -111,7 +111,7 @@ public class Example {
         NamespaceApi apiInstance = new NamespaceApi(defaultClient);
         DropNamespaceRequest dropNamespaceRequest = new DropNamespaceRequest(); // DropNamespaceRequest | 
         try {
-            Object result = apiInstance.dropNamespace(dropNamespaceRequest);
+            DropNamespaceResponse result = apiInstance.dropNamespace(dropNamespaceRequest);
             System.out.println(result);
         } catch (ApiException e) {
             System.err.println("Exception when calling NamespaceApi#dropNamespace");
@@ -133,7 +133,7 @@ public class Example {
 
 ### Return type
 
-**Object**
+[**DropNamespaceResponse**](DropNamespaceResponse.md)
 
 ### Authorization
 

java/lance-namespace-apache-client/src/main/java/com/lancedb/lance/namespace/client/apache/api/NamespaceApi.java

@@ -19,7 +19,9 @@
 import com.lancedb.lance.namespace.client.apache.Configuration;
 import com.lancedb.lance.namespace.client.apache.Pair;
 import com.lancedb.lance.namespace.client.apache.model.CreateNamespaceRequest;
+import com.lancedb.lance.namespace.client.apache.model.CreateNamespaceResponse;
 import com.lancedb.lance.namespace.client.apache.model.DropNamespaceRequest;
+import com.lancedb.lance.namespace.client.apache.model.DropNamespaceResponse;
 import com.lancedb.lance.namespace.client.apache.model.GetNamespaceRequest;
 import com.lancedb.lance.namespace.client.apache.model.GetNamespaceResponse;
 import com.lancedb.lance.namespace.client.apache.model.ListNamespacesRequest;
@@ -58,10 +60,10 @@ public NamespaceApi(ApiClient apiClient) {
    * with this name is created.
    *
    * @param createNamespaceRequest (required)
-   * @return GetNamespaceResponse
+   * @return CreateNamespaceResponse
    * @throws ApiException if fails to make API call
    */
-  public GetNamespaceResponse createNamespace(CreateNamespaceRequest createNamespaceRequest)
+  public CreateNamespaceResponse createNamespace(CreateNamespaceRequest createNamespaceRequest)
       throws ApiException {
     return this.createNamespace(createNamespaceRequest, Collections.emptyMap());
   }
@@ -76,10 +78,10 @@ public GetNamespaceResponse createNamespace(CreateNamespaceRequest createNamespa
    *
    * @param createNamespaceRequest (required)
    * @param additionalHeaders additionalHeaders for this call
-   * @return GetNamespaceResponse
+   * @return CreateNamespaceResponse
    * @throws ApiException if fails to make API call
    */
-  public GetNamespaceResponse createNamespace(
+  public CreateNamespaceResponse createNamespace(
       CreateNamespaceRequest createNamespaceRequest, Map<String, String> additionalHeaders)
       throws ApiException {
     Object localVarPostBody = createNamespaceRequest;
@@ -112,8 +114,8 @@ public GetNamespaceResponse createNamespace(
 
     String[] localVarAuthNames = new String[] {};
 
-    TypeReference<GetNamespaceResponse> localVarReturnType =
-        new TypeReference<GetNamespaceResponse>() {};
+    TypeReference<CreateNamespaceResponse> localVarReturnType =
+        new TypeReference<CreateNamespaceResponse>() {};
     return apiClient.invokeAPI(
         localVarPath,
         "POST",
@@ -134,10 +136,11 @@ public GetNamespaceResponse createNamespace(
    * Drop a namespace Drop a namespace. The namespace must be empty.
    *
    * @param dropNamespaceRequest (required)
-   * @return Object
+   * @return DropNamespaceResponse
    * @throws ApiException if fails to make API call
    */
-  public Object dropNamespace(DropNamespaceRequest dropNamespaceRequest) throws ApiException {
+  public DropNamespaceResponse dropNamespace(DropNamespaceRequest dropNamespaceRequest)
+      throws ApiException {
     return this.dropNamespace(dropNamespaceRequest, Collections.emptyMap());
   }
 
@@ -146,10 +149,10 @@ public Object dropNamespace(DropNamespaceRequest dropNamespaceRequest) throws Ap
    *
    * @param dropNamespaceRequest (required)
    * @param additionalHeaders additionalHeaders for this call
-   * @return Object
+   * @return DropNamespaceResponse
    * @throws ApiException if fails to make API call
    */
-  public Object dropNamespace(
+  public DropNamespaceResponse dropNamespace(
       DropNamespaceRequest dropNamespaceRequest, Map<String, String> additionalHeaders)
       throws ApiException {
     Object localVarPostBody = dropNamespaceRequest;
@@ -181,7 +184,8 @@ public Object dropNamespace(
 
     String[] localVarAuthNames = new String[] {};
 
-    TypeReference<Object> localVarReturnType = new TypeReference<Object>() {};
+    TypeReference<DropNamespaceResponse> localVarReturnType =
+        new TypeReference<DropNamespaceResponse>() {};
     return apiClient.invokeAPI(
         localVarPath,
         "POST",