feat: fill missing Hive definition and reorganize full text spec#115
Merged
Conversation
github-actions
Bot
added
enhancement
wojiaodoubao
reviewed
Jul 5, 2025
| TODO: add more information after implementation is officially added. No newline at end of file | ||
| ## Namespace Mapping | ||
|
|
||
| A HMS server can be viewed as the root Lance namespace, and a database in HMS maps to the first level Lance namespace |
Collaborator
There was a problem hiding this comment.
I'm still learning hms, so this question might be a little silly. I notice hms has catalog now and we choose to map database as the first level lance namespace. I think it means we only use the default catalog, right? Is this for better compatibility?
Collaborator
Author
There was a problem hiding this comment.
I notice hms has catalog now
oh that's a good point, I totally forgot that. Let me add it
yanghua
reviewed
Jul 7, 2025
| @@ -1,9 +1,29 @@ | |||
| # Introduction | |||
| # | |||
Contributor
There was a problem hiding this comment.
Missing top-level title? Or is it intentional?
Collaborator
Author
There was a problem hiding this comment.
oh that's a miss
yanghua
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in Hive namespace implementation spec with proper definition of how a Lance table should be stored. Also reorganize the original text spec into pieces for better readability.