feat: add listTables#117
Merged
Merged
Conversation
added 3 commits
July 5, 2025 16:49
github-actions
Bot
added
enhancement
wojiaodoubao
commented
Jul 5, 2025
| ListNamespacesRequest: | ||
| type: object | ||
| required: | ||
| - parent |
Collaborator
Author
There was a problem hiding this comment.
I think we need to make it required because 'https://github.com/lancedb/lance-namespace/blob/main/docs/src/spec/rest.yaml#L471'
Collaborator
There was a problem hiding this comment.
I don't think so, that is taking about the {id} in the route. Here the parent can be null, representing the root namespace. So the request will be:
POST /v1/table/./list
{}
Collaborator
Author
There was a problem hiding this comment.
I used to think using delimiter to represent the root namespace in parent. If I understand correctly, the {id} and parent don't need to be coupled together. Thanks your explanation, it makes sense to me. Let me fix it.
jackye1995
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.