From 518f6526259ec916287eada91a9b4ad886385ff9 Mon Sep 17 00:00:00 2001 From: Jack Ye Date: Mon, 7 Jul 2025 23:01:30 -0700 Subject: [PATCH] fix: add missing location configuration for Hive spec --- docs/src/spec/impls/hive.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/src/spec/impls/hive.md b/docs/src/spec/impls/hive.md index bd033c945..f02f2afe2 100644 --- a/docs/src/spec/impls/hive.md +++ b/docs/src/spec/impls/hive.md @@ -20,8 +20,9 @@ to form a 3-level Lance namespace as a whole. A Lance table should appear as a [Table object](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L631) in HMS with the following requirements: -1. the [tableType](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L643) must be set as `EXTERNAL_TABLE` to indicate this is not a managed Hive table -2. the [parameters](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L640) must follow: +1. the [`tableType`](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L643) must be set as `EXTERNAL_TABLE` to indicate this is not a managed Hive table +2. the [`location`](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L467) in [`storageDescriptor`](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L638) must point to the root location of the Lance table +3. the [`parameters`](https://github.com/apache/hive/blob/branch-4.0/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L640) must follow: 1. there is a key `table_type` set to `lance` (case insensitive) 2. there is a key `managed_by` set to either `storage` or `impl` (case insensitive). If not set, default to `storage` 3. there is a key `version` set to the latest numeric version number of the table. This field will only be respected if `managed_by=impl`