feat: fix java sdk query, table stats recursive structs, improve docs#136
Merged
Conversation
LuQQiu
commented
Jul 16, 2025
| ``` | ||
|
|
||
| ## Current Limitations | ||
| ## Known Limitations |
Contributor
Author
There was a problem hiding this comment.
@jackye1995 Updated the new known limitation. If i use OneOf, the created struct will be empty. I default to the simpler and more common one for now
Collaborator
There was a problem hiding this comment.
We can merge this and do it in the next PR if necessary, but I think you can look at https://github.com/lancedb/lance-namespace/blob/main/docs/src/spec/rest.yaml#L1928 I tried a few ways in the end I think overloading one field for one type seems to be the most compatible way in OpenAPI.
Contributor
Author
There was a problem hiding this comment.
Yep, have multiple ways to resolve it, let me try this approach, thanks for the suggestion!
jackye1995
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update query and table stats request/response structs to better match the server specification.
Improve the java sdk doc with list indices, get index stats and varies queries