feat: add glue listNamespaces support#140
Merged
Merged
Conversation
jackye1995
reviewed
Jul 21, 2025
jackye1995
reviewed
Jul 21, 2025
Collaborator
|
Thanks for the contribution! Mostly looks good to me, just a few nit comments. Also you might want to raise another PR to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays the initial groundwork for Lance namespace support in AWS Glue Catalog, starting with
ListNamespaces.In this approach, to support pagination correctly, I had to align Lance’s models to Glue’s bounds and restrictions. For example, Lance places no explicit bounds on pageSize, while Glue enforces a maximum of 100 results per call.
So I just fetches results from Glue in batches, continuing until either the requested page size is met or Glue has no more results.
Also, started the ground work for AWS clients by adding support for Static credentials, and fall back to default AWS credential provider chain.
Testing
./mvnw clean install