fix: add child field conversion support in JsonArrowSchemaConverter#187
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the JsonArrowSchemaConverter where child fields for complex Arrow types (list, struct, map) were not being converted, causing schema validation errors when creating Lance tables with array columns.
- Adds recursive conversion of child fields for complex Arrow types
- Maintains backward compatibility by handling cases where no child fields exist
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
…space/util/JsonArrowSchemaConverter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LuQQiu
changed the title
jackye1995
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug in
JsonArrowSchemaConverterwhere child fields for complex Arrow types (list, struct, map) were not being converted, causing "Lists have one child Field. Found: none" errors when creating Lance tables with array columns.