fix: pin async javadocs to Java 11#318
Merged
Merged
Conversation
Xuanwo
added a commit
that referenced
this pull request
Mar 16, 2026
The current Java publish `dry_run` only runs a plain `package`, so it misses failures that are specific to the `deploy-to-ossrh` profile and only show up during release publishing. This changes the dry run path to execute `verify -P deploy-to-ossrh -Dgpg.skip=true`, which exercises Javadoc generation and the publish profile without actually signing or deploying artifacts. I validated the new command locally on top of #318, and it successfully builds the async and core-async modules through the same Javadoc path that previously failed during release.
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/lance-namespace
that referenced
this pull request
Mar 16, 2026
The Java publish workflow for `v0.5.3` failed while generating Javadocs for the async modules because they use `java.net.http`, but the inherited Javadoc configuration was still resolved against Java 8 semantics. This change pins the async modules' Javadoc generation to Java 11 locally, without changing the root profile used by the synchronous modules. I validated this by rerunning the async Maven packaging path with `deploy-to-ossrh`; the original `package java.net.http does not exist` failure no longer reproduces and the build now advances to an unrelated external Javadoc link fetch error.
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/lance-namespace
that referenced
this pull request
Mar 16, 2026
The current Java publish `dry_run` only runs a plain `package`, so it misses failures that are specific to the `deploy-to-ossrh` profile and only show up during release publishing. This changes the dry run path to execute `verify -P deploy-to-ossrh -Dgpg.skip=true`, which exercises Javadoc generation and the publish profile without actually signing or deploying artifacts. I validated the new command locally on top of lance-format#318, and it successfully builds the async and core-async modules through the same Javadoc path that previously failed during release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java publish workflow for
v0.5.3failed while generating Javadocs for the async modules because they usejava.net.http, but the inherited Javadoc configuration was still resolved against Java 8 semantics. This change pins the async modules' Javadoc generation to Java 11 locally, without changing the root profile used by the synchronous modules.I validated this by rerunning the async Maven packaging path with
deploy-to-ossrh; the originalpackage java.net.http does not existfailure no longer reproduces and the build now advances to an unrelated external Javadoc link fetch error.