Skip to content

chore: add a root Makefile#50

Merged
jackye1995 merged 2 commits into
lance-format:mainfrom
jackye1995:makefile
Apr 22, 2025
Merged

chore: add a root Makefile#50
jackye1995 merged 2 commits into
lance-format:mainfrom
jackye1995:makefile

Conversation

@jackye1995
Copy link
Copy Markdown
Collaborator

Fixes #47

@github-actions github-actions Bot added chore Features related to test, build, style improvements java Java features labels Apr 21, 2025
Comment thread java/Makefile
./mvnw spotless:apply

build-java-apache-client: gen-java-apache-client
lint-java-apache-client: gen-java-apache-client gen-java-springboot-server
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to separate lint and codegen, becuase lint in java has to be run after all codegen completes otherwise it gives module not found error

@jackye1995 jackye1995 requested a review from yanghua April 21, 2025 17:46
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
@github-actions github-actions Bot added python Python features rust Rust features labels Apr 22, 2025
@jackye1995 jackye1995 requested a review from yanghua April 22, 2025 04:04
Copy link
Copy Markdown
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jackye1995 jackye1995 merged commit 89859cf into lance-format:main Apr 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Features related to test, build, style improvements java Java features python Python features rust Rust features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Makefile in root project

2 participants