spec: use dedicated response for DML operations#70
Merged
Conversation
github-actions
Bot
added
enhancement
jackye1995
commented
May 20, 2025
| additionalProperties: | ||
| type: string | ||
|
|
||
| CreateNamespaceResponse: |
Collaborator
Author
There was a problem hiding this comment.
Instead of making Create return Get response, we now have a dedicated create response. This is inspired by recent discussions in IRC that Create might need to return a transaction handle and the response would be different from a Get. Similarly, Alter and Drop should also have dedicated responses.
jackye1995
commented
May 20, 2025
yanghua
reviewed
May 20, 2025
jackye1995
changed the title
Contributor
|
This PR needs to be rebased. |
yanghua
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on similar discussions going on in Iceberg, DML operations might return different response compared to the DQL operations, e.g. CreateNamespace could return a transaction ID indicating the current running transaction, instead of returning the created namespace. In order to prevent forward incompatible changes, we provide a response to every DML operations, instead of returning null or using the Get operation response.