chore: leverage .openapi-generator-ignore in python client generation#82
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
|
@bxlq, thanks for your contribution, let me verify your changes. |
|
cc @jackye1995 |
jackye1995
left a comment
There was a problem hiding this comment.
Thanks for the fix! We should probably do the same for the other generated modules as well
|
Oh actually, I noticed one issue, when we do clean we remove the entire directory. That's why I put an external ignore file for the Apache client in Java. Can we do the same here? |
|
The Python OpenAPI code generation template is stingy and requires the ignore files to be located in the output directory. However, right now the To delete everything, including hidden files, we would need to add |
great! In that case I think we can also do the same for the apache client folder, instead of making an external ignore file so it is consistent. Merging this! |
This PR uses the
.openapi-generator-ignorefile for the Python client generation, instead of running manualrmcommands afterwards. The OpenAPI generator for the Python client requires the ignore file to be in the output directory.However, the generation metadata
.openapi-generator/is something that can't be skipped in the python client generation, but there are some open PRs to address this across all clients which seem to have been open for a while now. For example: OpenAPITools/openapi-generator#15770.I see that the repo is also cleaning
.openapi-generator-ignorefiles so feel free to close this if not needed.Testing
make clean-python && make gen-python