Commit 5689bd2
committed
review(R26): swap assertEquals arg order to (expected, actual)
R26 caught one assertEquals call at line 1139 in
testZonemapConsolidatedCommitShape with reversed JUnit 5 argument
order: `assertEquals(fragmentsIndexed, expectedFragments.size())`.
JUnit's signature is `assertEquals(expected, actual, message)`,
where the test author's known ground truth goes in the expected
slot and the value-under-test in the actual slot. With the
arguments swapped, a failure prints "expected: <SQL return> but
was: <dataset fragment count>" — misleading operators who'd
correlate the message against what they think the system should
do, not against the SQL return.
Swap to `assertEquals(expectedFragments.size(), (int) fragmentsIndexed)`.
Reset clean counter to 0/10.
Test count: 38 (unchanged), make lint passes, all green on 3.5/2.12.1 parent 11342ca commit 5689bd2
1 file changed
Lines changed: 1 addition & 1 deletion
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1137 | 1137 | | |
1138 | 1138 | | |
1139 | 1139 | | |
1140 | | - | |
1141 | 1140 | | |
| 1141 | + | |
1142 | 1142 | | |
1143 | 1143 | | |
1144 | 1144 | | |
| |||
0 commit comments