chore: remove RuntimeException string-parsing workaround for table-no… (#385)

…t-found errors

Now that lance#6275 is merged and the release is brought into Spark, the
namespace bridge properly throws LanceNamespaceException with
ErrorCode.TABLE_NOT_FOUND, making the message-matching fallback
unnecessary.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hamersaw

lance-spark-base_2.12/src/main/java/org/lance/spark/BaseLanceNamespaceSparkCatalog.java

@@ -1192,22 +1192,8 @@ private Table loadTableInternal(
    * Calls namespace.describeTable and translates table-not-found errors into Spark's {@link
    * NoSuchTableException}.
    *
-   * <p>Two catch blocks handle the error:
-   *
-   * <ol>
-   *   <li>{@link LanceNamespaceException} with {@link ErrorCode#TABLE_NOT_FOUND} — catches the
-   *       exception that the JNI bridge creates once the upstream lance-namespace-impls uses typed
-   *       {@code NamespaceError::TableNotFound} (see lance PR #6267 / #6275). This also covers
-   *       {@link TableNotFoundException} (a subclass of {@link LanceNamespaceException}).
-   *   <li>{@link RuntimeException} with message matching — workaround for the current state where
-   *       dir.rs and dir/manifest.rs use {@code Error::namespace_source(String)}, causing the JNI
-   *       downcast to {@code NamespaceError} to fail and fall back to a raw RuntimeException. Two
-   *       known message patterns: "Table does not exist: {name}" (dir.rs) and "Table '{name}' not
-   *       found" (manifest.rs).
-   * </ol>
-   *
-   * <p>TODO: Remove the RuntimeException catch block once lance fixes dir.rs and manifest.rs to use
-   * {@code NamespaceError::TableNotFound}.
+   * <p>Catches {@link LanceNamespaceException} with {@link ErrorCode#TABLE_NOT_FOUND}, which covers
+   * {@link TableNotFoundException} (a subclass of {@link LanceNamespaceException}).
    *
    * <p>This helper should be used at call sites where {@code NoSuchTableException} is the expected
    * outcome for missing tables (e.g. {@code loadTableInternal}, {@code stageReplace}). Call sites
@@ -1223,14 +1209,6 @@ private DescribeTableResponse describeTableOrThrow(DescribeTableRequest request,
         throw new NoSuchTableException(ident);
       }
       throw e;
-    } catch (RuntimeException e) {
-      String msg = e.getMessage();
-      if (msg != null
-          && (msg.contains("Table does not exist")
-              || (msg.contains("Table") && msg.contains("not found")))) {
-        throw new NoSuchTableException(ident);
-      }
-      throw e;
     }
   }
 

lance-spark-base_2.12/src/test/java/org/lance/spark/BaseTestSparkDirectorySingleLevelNsNamespace.java

@@ -27,11 +27,7 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-/**
- * Tests for DirectoryNamespace in single-level namespace mode (no manifest). This exercises the
- * dir.rs "Table does not exist" error path, which is different from the manifest.rs "Table '...'
- * not found" path tested in {@link BaseTestSparkDirectoryNamespace}.
- */
+/** Tests for DirectoryNamespace in single-level namespace mode (no manifest). */
 public abstract class BaseTestSparkDirectorySingleLevelNsNamespace {
   private SparkSession spark;
   private TableCatalog catalog;
@@ -66,14 +62,12 @@ void tearDown() {
   @Test
   public void testTableExistsReturnsFalseForNonExistentTable() {
     // In single-level mode, this goes through dir.rs check_table_status
-    // which produces "Table does not exist: {table_name}"
     assertFalse(catalog.tableExists(Identifier.of(new String[] {"default"}, "non_existent_table")));
   }
 
   @Test
   public void testLoadNonExistentTableThrowsNoSuchTableException() {
-    // Verifies that the "Table does not exist" message from dir.rs
-    // is correctly translated to NoSuchTableException
+    // Verifies that a missing table is correctly translated to NoSuchTableException
     assertThrows(
         NoSuchTableException.class,
         () -> catalog.loadTable(Identifier.of(new String[] {"default"}, "non_existent_table")));