Skip to content

Commit 8a8355a

Browse files
zhangyue19921010zhangyue19921010
andauthored
fix(ci): pin goosefs-sdk to 0.1.5 (#7798)
Pins goosefs-sdk to 0.1.5 because 0.1.6 fails to compile on Linux due to a missing std::ffi::CString import. This pin can be removed once upstream publishes a fixed release. ``` error[E0433]: cannot find type `CString` in this scope --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/goosefs-sdk-0.1.6/src/cache/store/uring/store.rs:314:23 | 314 | let cstring = CString::new(path) | ^^^^^^^ use of undeclared type `CString` ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Updated GooseFS integration to use a compatible SDK version, improving reliability for supported storage operations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: zhangyue19921010 <zhangyue.1010@bytedance.com>
1 parent 31a1e50 commit 8a8355a

5 files changed

Lines changed: 7 additions & 1 deletion

File tree

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ geoarrow-schema = "0.8"
154154
geodatafusion = "0.4.0"
155155
geo-traits = "0.3.0"
156156
geo-types = "0.7.16"
157+
goosefs-sdk = "=0.1.5"
157158
http = "1.1.0"
158159
humantime = "2.2.0"
159160
hyperloglogplus = { version = "0.4.1", features = ["const-loop"] }

java/lance-jni/Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/lance-io/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ byteorder.workspace = true
3535
bytes.workspace = true
3636
chrono.workspace = true
3737
futures.workspace = true
38+
goosefs-sdk = { workspace = true, optional = true }
3839
http.workspace = true
3940
log.workspace = true
4041
metrics = { workspace = true, optional = true }
@@ -76,7 +77,8 @@ gcp = ["object_store/gcp", "dep:opendal", "opendal/services-gcs", "dep:object_st
7677
aws = ["object_store/aws", "dep:aws-config", "dep:aws-credential-types", "dep:opendal", "opendal/services-s3", "dep:object_store_opendal"]
7778
azure = ["object_store/azure", "dep:opendal", "opendal/services-azblob", "opendal/services-azdls", "dep:object_store_opendal"]
7879
oss = ["dep:opendal", "opendal/services-oss", "dep:object_store_opendal"]
79-
goosefs = ["dep:opendal", "opendal/services-goosefs", "dep:object_store_opendal"]
80+
# Pin goosefs-sdk until a release fixes the missing CString import in 0.1.6's Linux backend.
81+
goosefs = ["dep:goosefs-sdk", "dep:opendal", "opendal/services-goosefs", "dep:object_store_opendal"]
8082
tencent = ["dep:opendal", "opendal/services-cos", "dep:object_store_opendal"]
8183
huggingface = ["dep:opendal", "opendal/services-huggingface", "dep:object_store_opendal"]
8284
tos = ["dep:opendal", "opendal/services-tos", "dep:object_store_opendal"]

0 commit comments

Comments
 (0)