Skip to content

Commit d087753

Browse files
Update rust/lance/src/dataset/write/merge_insert.rs
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent 88f80a5 commit d087753

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

rust/lance/src/dataset/write/merge_insert.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11522,10 +11522,10 @@ MergeInsert: on=[id], when_matched=DoNothing, when_not_matched=InsertAll, when_n
1152211522
.try_build()
1152311523
.unwrap();
1152411524

11525-
// This will crash due to LargeBinary vs Struct schema mismatch!
11526-
let result = job.execute_reader(new_reader).await;
11527-
// With AllBinary set, the partial update should succeed!
11528-
let (new_dataset, _stats) = result.unwrap();
11525+
// With AllBinary blob handling, the partial-schema update (source omits
11526+
// the `blobs` column) succeeds instead of failing with a LargeBinary vs
11527+
// Struct schema mismatch.
11528+
let (new_dataset, _stats) = job.execute_reader(new_reader).await.unwrap();
1152911529
assert_eq!(new_dataset.count_rows(None).await.unwrap(), 3);
1153011530

1153111531
let batches = new_dataset

0 commit comments

Comments
 (0)