Skip to content

Commit f2db129

Browse files
wjones127claude
andauthored
chore: upgrade Rust toolchain to 1.94.0 (#6460)
Upgrades the pinned Rust toolchain from 1.91.0 to 1.94.0. The only code change needed was boxing two futures in `build_partial_fixture` in the `distributed_vector_build` bench, where 1.94's stricter layout computation overflowed the default recursion limit. Boxing makes the awaited futures' sizes constant (a pointer), breaking the recursion. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent bec9491 commit f2db129

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

java/lance-jni/src/session.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ use lance::session::Session as LanceSession;
1111
use lance_io::object_store::ObjectStoreRegistry;
1212

1313
use crate::error::{Error, Result};
14-
use crate::ok_or_throw_with_return;
1514

1615
/// Creates a new Session and returns a handle to it.
1716
///

rust-toolchain.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# We keep this pinned to keep clippy and rustfmt in sync between local and CI.
22
# Feel free to upgrade to bring in new lints.
33
[toolchain]
4-
channel = "1.91.0"
4+
channel = "1.94.0"
55
components = ["rustfmt", "clippy", "rust-analyzer"]

rust/lance/benches/distributed_vector_build.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,8 @@ async fn build_partial_fixture(dataset: &mut Dataset, bench_case: BenchCase) ->
281281
}
282282

283283
let fragment_groups = contiguous_fragment_groups(dataset, bench_case.num_shards);
284-
let (ivf_params, pq_params) = train_shared_ivf_pq(dataset, bench_case.num_partitions).await;
284+
let (ivf_params, pq_params) =
285+
Box::pin(train_shared_ivf_pq(dataset, bench_case.num_partitions)).await;
285286
let params = VectorIndexParams::with_ivf_pq_params(DistanceType::L2, ivf_params, pq_params);
286287

287288
for fragments in fragment_groups {
@@ -290,7 +291,7 @@ async fn build_partial_fixture(dataset: &mut Dataset, bench_case: BenchCase) ->
290291
.name("distributed_merge_only".to_string())
291292
.fragments(fragments)
292293
.index_uuid(fixture_uuid.to_string());
293-
builder.execute_uncommitted().await.unwrap();
294+
Box::pin(builder.execute_uncommitted()).await.unwrap();
294295
}
295296

296297
MergeFixture {

rust/lance/src/dataset/write.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ impl WriteParams {
428428
/// IDs can be assigned after writing is complete.
429429
#[deprecated(
430430
since = "0.20.0",
431-
note = "Use [`InsertBuilder::write_uncommitted_stream`] instead"
431+
note = "Use [`InsertBuilder::execute_uncommitted_stream`] instead"
432432
)]
433433
pub async fn write_fragments(
434434
dest: impl Into<WriteDestination<'_>>,

0 commit comments

Comments
 (0)