feat: make Dataset::object_store sync by pre-initializing base stores#6670
Open
jackye1995 wants to merge 3 commits intolance-format:mainfrom
Open
feat: make Dataset::object_store sync by pre-initializing base stores#6670jackye1995 wants to merge 3 commits intolance-format:mainfrom
jackye1995 wants to merge 3 commits intolance-format:mainfrom
Conversation
Pre-initialize all base object stores during Dataset construction and cache them in a HashMap<u32, Arc<ObjectStore>>. This makes object_store() a sync HashMap lookup instead of an async ObjectStore::from_uri_and_params call on every access. Changes: - Add base_object_stores field to Dataset - init_base_object_stores called during open/checkout - object_store(), object_store_for_data_file, object_store_for_deletion, object_store_for_index are now sync - with_object_store_wrappers re-wraps cached base stores - All ~40 call sites updated to remove .await
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datasetconstruction and cache them inHashMap<u32, Arc<ObjectStore>>Dataset::object_store(base_id)is now a sync HashMap lookup instead of an asyncObjectStore::from_uri_and_paramscallobject_store_for_data_file,object_store_for_deletion,object_store_for_indexare also syncwith_object_store_wrappersre-wraps cached base stores alongside the primary store.await