Skip to content

fix: always do wal tailer cursor update#6673

Merged
jackye1995 merged 1 commit intolance-format:mainfrom
touch-of-grey:jack/wal-tailer-cursor-update
May 3, 2026
Merged

fix: always do wal tailer cursor update#6673
jackye1995 merged 1 commit intolance-format:mainfrom
touch-of-grey:jack/wal-tailer-cursor-update

Conversation

@touch-of-grey
Copy link
Copy Markdown
Contributor

Summary

  • Switch WAL entry positions to 0-based; appender uses the manifest wal_entry_position_last_seen hint with HEAD probing to discover its next write position, falling back to a directory listing only when the hint is stale.
  • WalTailer always emits a best-effort manifest cursor update on successful read_entry (removes the opt-in with_cursor_updates flag).
  • Extract the shared HEAD-probe loop into probe_forward_from().

cc @jackye1995 for review.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@touch-of-grey
Copy link
Copy Markdown
Contributor Author

@jackye1995 could you take a look?

@github-actions github-actions Bot added the bug Something isn't working label May 3, 2026
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 75.40984% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/mem_wal/wal.rs 75.40% 13 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@jackye1995 jackye1995 merged commit 170446a into lance-format:main May 3, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants