fix: add equals/hashCode to FullTextQuery concrete subclasses#6674
Open
ivscheianu wants to merge 4 commits intolance-format:mainfrom
Open
fix: add equals/hashCode to FullTextQuery concrete subclasses#6674ivscheianu wants to merge 4 commits intolance-format:mainfrom
ivscheianu wants to merge 4 commits intolance-format:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
… into full-text-query-eq-and-hashcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adding
equals()andhashCode()toMatchQuery,PhraseQuery, andMultiMatchQueryinFullTextQuery.Why
The concrete subclasses currently inherit reference equality from
Object. Two independently constructed instances with identical fields are notequals()and produce different hash codes.This was surfaced while trying to sketch an impl for SQL FTS query support in lance-spark, which allows users to push
lance_match,lance_phrase, andlance_multi_matchpredicates down to the Lance FTS inverted index at query planning time. That work requires transportingFullTextQueryinstances across the driver -> executor boundary, serializing them to a stable intermediate form and reconstructing them on the other side. Without structural equality, comparing a reconstructed instance to the original always returnsfalseeven when every field is identical, making correct scan identity checks impossible.More broadly, any consumer that serializes a
FullTextQueryand reconstructs it later faces the same problem. The fix is mechanical and non-breaking: callers that never compared these objects structurally are unaffected.