Skip to content

fix: accept traces key in trace messages#122

Draft
Ramon Nogueira (ramon-langchain) wants to merge 1 commit into
mainfrom
ramonn/trace-messages-response-compat
Draft

fix: accept traces key in trace messages#122
Ramon Nogueira (ramon-langchain) wants to merge 1 commit into
mainfrom
ramonn/trace-messages-response-compat

Conversation

@ramon-langchain
Copy link
Copy Markdown
Member

Summary

  • accept either items or traces from /v2/traces/messages
  • keep feedback_stats output intact for both traces with and without feedback
  • set the feedback stats test to JSON mode before parsing output

Test Plan

  • go test ./internal/cmd -run 'TestTraceMessages'
  • deslop internal/cmd/message.go internal/cmd/message_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant