feat: add sandbox remote-run (rr)#175
feat: add sandbox remote-run (rr)#175Mukil Loganathan (langchain-infra) wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
0d2cebc to
2573af3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2573af3 to
e0f399e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
e0f399e to
7248a6e
Compare
Adds `langsmith sandbox remote-run` (alias `rr`): mirror the current git worktree into a LangSmith sandbox and run a command there. It creates or starts a deterministic per-user sandbox, provisions SSH/rsync inside it, syncs committed (HEAD) plus uncommitted local changes, and runs the command from the mirrored checkout. Supports named sandboxes, snapshot selection, opt-in secrets sync, and port tunneling (`--tunnel` forwards every port in `.env.ports.override` to localhost while the command runs).
7248a6e to
f533a2a
Compare
| cmd.Flags().BoolVar(&in.WorktreeSandbox, "worktree-sandbox", in.WorktreeSandbox, "Use a sandbox name derived from the current worktree instead of git user.email") | ||
| cmd.Flags().BoolVar(&in.NoSync, "no-sync", in.NoSync, "Skip pushing and rsyncing the repo; run against the sandbox's existing checkout") | ||
| cmd.Flags().BoolVar(&in.NoMise, "no-mise", in.NoMise, "Run the command directly instead of through mise") | ||
| cmd.Flags().BoolVar(&in.Tunnel, "tunnel", in.Tunnel, "Forward every port in .env.ports.override to localhost and keep running after the command") |
There was a problem hiding this comment.
🔍 Tunnel flag description implies persistent forwarding with commands, but forwards close when command exits
The --tunnel flag description at line 108 says 'keep running after the command', but when both --tunnel and a command are provided, the port forwards are attached to the SSH session running the command (internal/cmd/sandbox_remote_run.go:462). When the command exits, SSH exits and forwards close. Persistent forwarding only happens when --tunnel is used without a command (lines 455-459, which calls rrSSHTunnelConn). The flag description could be clarified to distinguish these two modes.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
Adds
langsmith sandbox remote-run(aliasrr): mirror the current git worktree into a LangSmith sandbox and run a command there.dev-<git user.email>by default;--sandbox/--worktree-sandboxto override).sshd+rsyncin the box, opens an SSH tunnel to it.miseunless--no-mise).--tunnelforwards every port in.env.ports.overrideto localhost while the command runs.git,ssh,rsync, and GitHub CLI auth (orGH_TOKEN/GITHUB_TOKEN) for private-repo cloning inside the box.Provenance
Prototyped in the downstream monorepo mirror (
langchain-ai/langchainplusPR #29607) and moved here to the source-of-truth CLI repo. It will flow back intolangchainplus/sdks/clivia the usual resync.Test plan
go build ./...,go test ./internal/cmd/...,gofmt— all green (5rrunit tests + existing sandbox tests).sandbox rr --sandbox <box> -- …— committed HEAD and an untracked file both landed in the mirrored worktree on the box.sandbox rr --tunnel -- <server>— a port from.env.ports.overridewas forwarded to localhost; reached the in-box server through it and pulled synced files back; forward closed cleanly on exit.