Skip to content

feat: remove redundant/dead UI fields from core components#12451

Open
RamGopalSrikar wants to merge 3 commits into
release-1.9.0from
ux/component-field-cleanup
Open

feat: remove redundant/dead UI fields from core components#12451
RamGopalSrikar wants to merge 3 commits into
release-1.9.0from
ux/component-field-cleanup

Conversation

@RamGopalSrikar
Copy link
Copy Markdown
Contributor

Summary

  • Removes 40+ redundant, dead-code, and confusing input fields across 17 core components based on a UI/UX review
  • Three recurring themes: API key fields (managed centrally via Model Provider, now hardcoded as None), dead-code fields (values never read or always overridden), and fields where a sensible default should just be hardcoded

Changes by component

Component Fields removed / changed
ChatInput should_store_message, sender, context_id
ChatOutput should_store_message, sender, sender_name, context_id, data_template
APIRequest save_to_file, include_httpx_metadata; query_params now hidden when method = GET
URLComponent headers, check_response_status, autoset_encoding
WebSearch ceid (was rebuilt from gl/hl anyway)
SQLExecutor include_columns (hardcoded True)
LanguageModel api_key
EmbeddingModel api_key, show_progress_bar, chunk_size
Agent api_key, max_tokens, format_instructions, output_schema
Guardrails api_key
SmartRouter api_key
SmartTransform api_key, sample_size, max_size; data renamed to "Input"
StructuredOutput api_key, system_prompt (extracted to _DEFAULT_FORMAT_INSTRUCTIONS constant)
Memory sender_type (always fetches all senders)
PromptTemplate tool_placeholder hidden (show=False)
KnowledgeIngestion api_key removed from new-KB dialog
BaseFileComponent silent_errors, ignore_unsupported_extensions (errors now always propagate)

Test plan

  • make format_backend passes (verified clean before this PR)
  • Place each modified component on the canvas — confirm removed fields no longer appear in the advanced panel
  • Run a simple Agent + Language Model flow to confirm model execution works without the api_key override field
  • Run a Structured Output flow to confirm extraction works with hardcoded format instructions
  • Run a Chat Input → Chat Output flow to confirm messages are stored correctly

🤖 Generated with Claude Code

Cleans up 17 component files based on UI/UX review. Three recurring
themes: API key fields are now always passed as None (managed centrally
via Model Provider), dead-code fields are removed, and sensible defaults
are hardcoded internally.

Changes by category:
- Chat I/O: remove should_store_message, sender, context_id, sender_name,
  data_template from ChatInput/ChatOutput; always store, always use AI/User
  sender constants
- API Request: remove save_to_file, include_httpx_metadata; add
  query_params visibility toggle when method != GET
- URL: remove headers, check_response_status, autoset_encoding; hardcode
  defaults in _create_loader()
- Web Search: remove ceid (was rebuilt from gl/hl anyway)
- SQL Executor: remove include_columns; hardcode True
- Language Model / Embedding Model / Agent / Guardrails / Smart Router /
  Smart Transform / Structured Output: remove api_key fields (11 components)
- Embedding Model: also remove show_progress_bar, chunk_size
- Memory: remove sender_type; always fetch all senders
- Prompt: hide tool_placeholder (show=False)
- Agent: also remove max_tokens, format_instructions, output_schema
- Smart Transform: rename data display_name "JSON"→"Input"; replace
  sample_size/max_size inputs with _SAMPLE_SIZE/_MAX_SIZE constants
- Structured Output: remove system_prompt input; add
  _DEFAULT_FORMAT_INSTRUCTIONS module constant
- Knowledge Ingestion: remove api_key from NewKnowledgeBaseInput dialog
- BaseFileComponent: remove silent_errors, ignore_unsupported_extensions
  inputs; errors now always propagate

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f3c90fc9-e2dc-40e7-bd83-90b0c25d041f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ux/component-field-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added community Pull Request from an external contributor enhancement New feature or request labels Apr 1, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 1, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 28%
28.01% (29184/104184) 64.76% (3717/5739) 30.03% (689/2294)

Unit Test Results

Tests Skipped Failures Errors Time
3014 0 💤 0 ❌ 0 🔥 4m 42s ⏱️

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.91%. Comparing base (389f702) to head (ad00142).
⚠️ Report is 10 commits behind head on release-1.9.0.

❌ Your project check has failed because the head coverage (45.53%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.0   #12451      +/-   ##
=================================================
+ Coverage          48.86%   48.91%   +0.05%     
=================================================
  Files               1897     1897              
  Lines             167656   167656              
  Branches           23193    24379    +1186     
=================================================
+ Hits               81928    82012      +84     
+ Misses             84817    84733      -84     
  Partials             911      911              
Flag Coverage Δ
frontend 48.28% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lfx/src/lfx/base/data/base_file.py 36.09% <ø> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Pull Request from an external contributor enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant