feat: remove redundant/dead UI fields from core components#12451
feat: remove redundant/dead UI fields from core components#12451RamGopalSrikar wants to merge 3 commits into
Conversation
Cleans up 17 component files based on UI/UX review. Three recurring themes: API key fields are now always passed as None (managed centrally via Model Provider), dead-code fields are removed, and sensible defaults are hardcoded internally. Changes by category: - Chat I/O: remove should_store_message, sender, context_id, sender_name, data_template from ChatInput/ChatOutput; always store, always use AI/User sender constants - API Request: remove save_to_file, include_httpx_metadata; add query_params visibility toggle when method != GET - URL: remove headers, check_response_status, autoset_encoding; hardcode defaults in _create_loader() - Web Search: remove ceid (was rebuilt from gl/hl anyway) - SQL Executor: remove include_columns; hardcode True - Language Model / Embedding Model / Agent / Guardrails / Smart Router / Smart Transform / Structured Output: remove api_key fields (11 components) - Embedding Model: also remove show_progress_bar, chunk_size - Memory: remove sender_type; always fetch all senders - Prompt: hide tool_placeholder (show=False) - Agent: also remove max_tokens, format_instructions, output_schema - Smart Transform: rename data display_name "JSON"→"Input"; replace sample_size/max_size inputs with _SAMPLE_SIZE/_MAX_SIZE constants - Structured Output: remove system_prompt input; add _DEFAULT_FORMAT_INSTRUCTIONS module constant - Knowledge Ingestion: remove api_key from NewKnowledgeBaseInput dialog - BaseFileComponent: remove silent_errors, ignore_unsupported_extensions inputs; errors now always propagate Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (45.53%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.9.0 #12451 +/- ##
=================================================
+ Coverage 48.86% 48.91% +0.05%
=================================================
Files 1897 1897
Lines 167656 167656
Branches 23193 24379 +1186
=================================================
+ Hits 81928 82012 +84
+ Misses 84817 84733 -84
Partials 911 911
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
None), dead-code fields (values never read or always overridden), and fields where a sensible default should just be hardcodedChanges by component
ChatInputshould_store_message,sender,context_idChatOutputshould_store_message,sender,sender_name,context_id,data_templateAPIRequestsave_to_file,include_httpx_metadata;query_paramsnow hidden when method = GETURLComponentheaders,check_response_status,autoset_encodingWebSearchceid(was rebuilt fromgl/hlanyway)SQLExecutorinclude_columns(hardcodedTrue)LanguageModelapi_keyEmbeddingModelapi_key,show_progress_bar,chunk_sizeAgentapi_key,max_tokens,format_instructions,output_schemaGuardrailsapi_keySmartRouterapi_keySmartTransformapi_key,sample_size,max_size;datarenamed to"Input"StructuredOutputapi_key,system_prompt(extracted to_DEFAULT_FORMAT_INSTRUCTIONSconstant)Memorysender_type(always fetches all senders)PromptTemplatetool_placeholderhidden (show=False)KnowledgeIngestionapi_keyremoved from new-KB dialogBaseFileComponentsilent_errors,ignore_unsupported_extensions(errors now always propagate)Test plan
make format_backendpasses (verified clean before this PR)api_keyoverride field🤖 Generated with Claude Code