Ux/component field cleanup#12468
Closed
RamGopalSrikar wants to merge 3 commits into
Closed
Conversation
Cleans up 17 component files based on UI/UX review. Three recurring themes: API key fields are now always passed as None (managed centrally via Model Provider), dead-code fields are removed, and sensible defaults are hardcoded internally. Changes by category: - Chat I/O: remove should_store_message, sender, context_id, sender_name, data_template from ChatInput/ChatOutput; always store, always use AI/User sender constants - API Request: remove save_to_file, include_httpx_metadata; add query_params visibility toggle when method != GET - URL: remove headers, check_response_status, autoset_encoding; hardcode defaults in _create_loader() - Web Search: remove ceid (was rebuilt from gl/hl anyway) - SQL Executor: remove include_columns; hardcode True - Language Model / Embedding Model / Agent / Guardrails / Smart Router / Smart Transform / Structured Output: remove api_key fields (11 components) - Embedding Model: also remove show_progress_bar, chunk_size - Memory: remove sender_type; always fetch all senders - Prompt: hide tool_placeholder (show=False) - Agent: also remove max_tokens, format_instructions, output_schema - Smart Transform: rename data display_name "JSON"→"Input"; replace sample_size/max_size inputs with _SAMPLE_SIZE/_MAX_SIZE constants - Structured Output: remove system_prompt input; add _DEFAULT_FORMAT_INSTRUCTIONS module constant - Knowledge Ingestion: remove api_key from NewKnowledgeBaseInput dialog - BaseFileComponent: remove silent_errors, ignore_unsupported_extensions inputs; errors now always propagate Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedToo many files! This PR contains 298 files, which is 148 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (298)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.