fix(flows): escape wildcard flow names when deduplicating#12493
Open
suyua9 wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIKEwildcards when searching for existing numbered copies in_deduplicate_flow_name()%and_in flow names so unrelated matches no longer inflate the next suffixTesting
git diff --check -- src/backend/base/langflow/api/v1/flows_helpers.py src/backend/tests/unit/api/v1/test_rename_flow_to_save.pypython3 -m py_compile src/backend/base/langflow/api/v1/flows_helpers.py src/backend/tests/unit/api/v1/test_rename_flow_to_save.pyuvx ruff check src/backend/base/langflow/api/v1/flows_helpers.py src/backend/tests/unit/api/v1/test_rename_flow_to_save.pyuv run python -m pytest -q tests/unit/api/v1/test_rename_flow_to_save.py -k "duplicate_flow_name_escapes_like_wildcards or duplicate_flow_name_regex_patterns"(started locally but did not return in a reasonable time window in this checkout; repository CI should provide the authoritative run)