Skip to content

fix(tests): Restore Windows-compatible slider Playwright test #12904

Merged
Cristhianzl merged 7 commits into
release-1.10.0from
cz/fix-slider-win
Apr 27, 2026
Merged

fix(tests): Restore Windows-compatible slider Playwright test #12904
Cristhianzl merged 7 commits into
release-1.10.0from
cz/fix-slider-win

Conversation

@Cristhianzl

@Cristhianzl Cristhianzl commented Apr 27, 2026

Copy link
Copy Markdown
Member

OBJECTIVE: Fix theslider component E2E test that was failing on Windows CI because the hidden <Input> mirror strips newlines from .value, causing the original Python source to reach the backend on a single line and the new range_spec to never be applied.

CHANGES:

  • Read the original component code from the value= HTML attribute via outerHTML instead of <Input>.value — single-line inputs strip \n from the DOM property, but the attribute keeps newlines intact
  • Decode HTML entities (&#10;, &#xA;, etc.) when extracting the attribute so multi-line Python is recovered exactly
  • Replace the Ace setter with the same textarea.last().fill() pattern queryInputComponent uses successfully on Windows, ensuring react-ace propagates the change to React state before save
  • Add a sanity-check that the extracted code has ≥50 newlines to surface a precise diagnostic if upstream regresses

@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d6ba74af-1ec7-4eb5-a968-b0b669f05837

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cz/fix-slider-win

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Apr 27, 2026
@Cristhianzl Cristhianzl enabled auto-merge April 27, 2026 17:38
@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Apr 27, 2026
@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.68%. Comparing base (fc7f6c4) to head (298fa96).
⚠️ Report is 11 commits behind head on release-1.10.0.

❌ Your project status has failed because the head coverage (49.90%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #12904      +/-   ##
==================================================
+ Coverage           53.17%   53.68%   +0.51%     
==================================================
  Files                2033     2035       +2     
  Lines              184601   184926     +325     
  Branches            27788    26410    -1378     
==================================================
+ Hits                98164    99283    +1119     
+ Misses              85337    84538     -799     
- Partials             1100     1105       +5     
Flag Coverage Δ
backend 56.27% <ø> (+0.08%) ⬆️
frontend 53.97% <ø> (+0.71%) ⬆️
lfx 49.90% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 117 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 36%
36.29% (41862/115337) 67.79% (5744/8473) 36.27% (966/2663)

Unit Test Results

Tests Skipped Failures Errors Time
4081 0 💤 0 ❌ 0 🔥 8m 20s ⏱️

@Cristhianzl Cristhianzl added this pull request to the merge queue Apr 27, 2026
Merged via the queue into release-1.10.0 with commit 2f51b7e Apr 27, 2026
177 of 178 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-slider-win branch April 27, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants