fix(tests): Restore Windows-compatible slider Playwright test #12904
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (49.90%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #12904 +/- ##
==================================================
+ Coverage 53.17% 53.68% +0.51%
==================================================
Files 2033 2035 +2
Lines 184601 184926 +325
Branches 27788 26410 -1378
==================================================
+ Hits 98164 99283 +1119
+ Misses 85337 84538 -799
- Partials 1100 1105 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
OBJECTIVE: Fix theslider component E2E test that was failing on Windows CI because the hidden
<Input>mirror strips newlines from.value, causing the original Python source to reach the backend on a single line and the new range_spec to never be applied.CHANGES:
value=HTML attribute viaouterHTMLinstead of<Input>.value— single-line inputs strip\nfrom the DOM property, but the attribute keeps newlines intact ,
, etc.) when extracting the attribute so multi-line Python is recovered exactlytextarea.last().fill()pattern queryInputComponent uses successfully on Windows, ensuringreact-acepropagates the change to React state before save