Skip to content

test: fix flow state clean test on windows#13013

Merged
Cristhianzl merged 1 commit into
release-1.10.0from
cz/fix-flow-state-test
May 7, 2026
Merged

test: fix flow state clean test on windows#13013
Cristhianzl merged 1 commit into
release-1.10.0from
cz/fix-flow-state-test

Conversation

@Cristhianzl

Copy link
Copy Markdown
Member

This pull request updates the user flow state cleanup end-to-end tests to improve reliability, especially on slower environments like Windows CI. The main changes focus on making the login and loading steps more robust by synchronizing on specific network responses and increasing timeouts for slow operations.

Test reliability and robustness improvements:

  • Replaced simple "Sign In" button clicks with a Promise.all that waits for both the button click and the corresponding /api/v1/login network response, ensuring the login process completes before proceeding. [1] [2] [3]
  • Increased timeouts for waiting on selectors that are slow to appear in CI environments, such as mainpage_title, new-project-btn, and canvas_controls_dropdown, to reduce test flakiness. [1] [2] [3]

@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c462ba78-e535-47d4-b9be-a8839832822a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cz/fix-flow-state-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Cristhianzl Cristhianzl changed the title tests: fix flow state clean test on windows test: fix flow state clean test on windows May 6, 2026
@github-actions github-actions Bot added the test Changes to tests label May 6, 2026
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.34%. Comparing base (30ac789) to head (c2a9bcd).

❌ Your project check has failed because the head coverage (50.60%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #13013      +/-   ##
==================================================
+ Coverage           54.31%   54.34%   +0.02%     
==================================================
  Files                2091     2091              
  Lines              191724   191724              
  Branches            27448    27455       +7     
==================================================
+ Hits               104142   104186      +44     
+ Misses              86427    86382      -45     
- Partials             1155     1156       +1     
Flag Coverage Δ
backend 57.60% <ø> (+0.05%) ⬆️
frontend 54.44% <ø> (+0.02%) ⬆️
lfx 50.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 37%
37.46% (44822/119652) 67.62% (6198/9165) 37.13% (1029/2771)

Unit Test Results

Tests Skipped Failures Errors Time
4253 0 💤 0 ❌ 0 🔥 9m 40s ⏱️

@Cristhianzl Cristhianzl merged commit abbe917 into release-1.10.0 May 7, 2026
177 of 178 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-flow-state-test branch May 7, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Changes to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant