chore: prevent UnicodeEncodeError crashing error logging on Windows consoles#13482
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR adds Unicode encoding resilience to stdout and stderr by reconfiguring them to use ChangesStream Resilience Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #13482 +/- ##
==================================================
- Coverage 57.76% 48.32% -9.44%
==================================================
Files 2271 2129 -142
Lines 216876 204411 -12465
Branches 32450 14576 -17874
==================================================
- Hits 125272 98779 -26493
- Misses 90185 104212 +14027
- Partials 1419 1420 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
On Windows CI, the e2e test
validate-raise-errors-components.spec.tsfailsdeterministically — it times out waiting for the error popup text
THIS IS A TEST ERROR MESSAGEto appear, even with the wait already bumped to30s on
release-1.10.0(all 4 attempts failed).Summary by CodeRabbit
Bug Fixes
Tests