ci: adjust zizmor advanced security handling#41
Conversation
|
| Experiment | Status | Actions |
|---|---|---|
| Uppercase (py) | ✅ Pass | View GitHub Action Run · View in Langfuse |
| Uppercase (ts) | ✅ Pass | View GitHub Action Run · View in Langfuse |
| Mixed dir (node) | ✅ Pass | View GitHub Action Run · View in Langfuse |
| Mixed dir (python) | ✅ Pass | View GitHub Action Run · View in Langfuse |
| Regression fixture | ❌ Regression | View GitHub Action Run · View in Langfuse |
Details
|
@claude review |
There was a problem hiding this comment.
LGTM — conditional advanced-security toggle is the standard pattern for letting fork PRs run code scanning workflows.
Extended reasoning...
Overview
This PR modifies only .github/workflows/zizmor.yml: it adds a merge_group trigger, passes advanced-security: ${{ github.event_name == 'push' && 'true' || 'false' }} to zizmor-action, and sets min-severity: low. No source code, no action logic, and no secrets handling are touched.
Security risks
None of concern. Disabling SARIF/Code Scanning upload on fork PRs is the established pattern — forks lack security-events: write against the base repo and cannot upload SARIF anyway, so this only removes a guaranteed failure. SARIF upload remains enabled on trusted push events to main, preserving the security signal. Lowering min-severity to low only makes the scan stricter (more findings reported), not laxer.
Level of scrutiny
Low. This is a CI-only configuration change confined to a single workflow file, addressing a well-known limitation of GitHub Advanced Security on fork PRs. The conditional expression is a standard GitHub Actions idiom.
Other factors
The bug hunting system found no issues. The pinned action SHA is unchanged. No outstanding reviewer comments to address.
What changed
zizmor-actionwithadvanced-security: falsefor non-pushevents, including pull requests and merge queue runs.pushevents.min-severity: lowfor the zizmor scan.Why
Fork pull requests cannot upload code scanning results to GitHub Advanced Security, so requiring zizmor code scanning results blocks community PRs. This keeps the check usable for fork PRs while preserving SARIF upload on trusted pushes.
Validation
.github/workflows/zizmor.ymlgit diff --check -- .github/workflows/zizmor.yml