Skip to content

docs(cookbook): add missing ddgs dependency to smolagents integration#2880

Open
meatballg1210 wants to merge 1 commit intolangfuse:mainfrom
meatballg1210:meatballg1210-patch-1
Open

docs(cookbook): add missing ddgs dependency to smolagents integration#2880
meatballg1210 wants to merge 1 commit intolangfuse:mainfrom
meatballg1210:meatballg1210-patch-1

Conversation

@meatballg1210
Copy link
Copy Markdown

@meatballg1210 meatballg1210 commented Apr 28, 2026

Problem

The smolagents integration notebook uses DuckDuckGoSearchTool in Step 4,
but the install command in Step 1 does not include the ddgs package.

ddgs is listed under smolagents' toolkit optional dependency group
(see pyproject.toml),
not under telemetry, so it is not installed by smolagents[telemetry].

This causes ModuleNotFoundError: No module named 'ddgs' when users run
DuckDuckGoSearchTool().

Verification

Tested in a clean Google Colab environment:

  • Without ddgs: DuckDuckGoSearchTool() fails with ModuleNotFoundError
  • With ddgs added: works correctly

Changes

Added ddgs to the pip install command in Step 1.

Disclaimer: Experimental PR review

Greptile Summary

This PR adds ddgs as an explicit dependency to the smolagents integration notebook's install step, fixing a ModuleNotFoundError that users hit when running DuckDuckGoSearchTool() in Step 4. The fix is correct — ddgs is part of smolagents[toolkit], not smolagents[telemetry], so it was never installed by the existing command.

Confidence Score: 5/5

Safe to merge — single-line dependency addition that fixes a confirmed runtime error for notebook users.

The change is minimal and targeted: one package added to one install cell. The fix is verified correct by the author and consistent with smolagents' published dependency structure. No logic or API changes introduced.

No files require special attention.

Important Files Changed

Filename Overview
cookbook/integration_smolagents.ipynb Adds ddgs to the pip install command to satisfy the DuckDuckGoSearchTool dependency used later in the notebook.

Sequence Diagram

sequenceDiagram
    participant User as Notebook User
    participant pip as pip install
    participant smolagents as smolagents[telemetry]
    participant ddgs as ddgs
    participant Tool as DuckDuckGoSearchTool

    User->>pip: %pip install ... smolagents[telemetry] ddgs
    pip->>smolagents: install telemetry extras
    pip->>ddgs: install ddgs (NEW)
    User->>Tool: DuckDuckGoSearchTool()
    ddgs-->>Tool: module available ✓
    Tool-->>User: search results
Loading

Reviews (1): Last reviewed commit: "docs(cookbook): add missing ddgs depende..." | Re-trigger Greptile

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

@meatballg1210 is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. docs labels Apr 28, 2026
The smolagents integration notebook uses DuckDuckGoSearchTool in Step 4, 
but ddgs is not installed by smolagents[telemetry]. 
It belongs to the toolkit optional group in smolagents' pyproject.toml.
This causes ModuleNotFoundError when users follow the notebook.
@meatballg1210 meatballg1210 force-pushed the meatballg1210-patch-1 branch from cbddfc9 to 9099951 Compare May 3, 2026 06:29
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 3, 2026

CLA assistant check
All committers have signed the CLA.

@meatballg1210
Copy link
Copy Markdown
Author

Hi maintainers 👋 Quick update: the CLA has been signed and that check is now passing . The remaining CI workflows and Vercel deployment still need approval from your side. It would be great if someone could approve them when you have a moment. Happy to make any changes if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants