Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
…sion - ChipCard baseClassName: drop legacy transition-colors duration-120 so tailwind-merge stops eating the new transition-[background] duration-180 (both shared the transition + transition-duration conflict groups, and the later utilities were winning silently). - FeaturedCustomers: scope the customer-name link group as group/story-link so adding hoverStripes (which adds an unnamed .group to the outer CornerBox) no longer triggers the underline when hovering anywhere else in the card. Made-with: Cursor
Use `group/box` instead of unnamed `group` on hoverStripes CornerBoxes so nested `group-hover:` (e.g. secondary Button border) only reacts to its own `button-wrapper` group, not card-wide hover. Update BulletList and Link `text` variant with `group-hover/box:` where needed so OpenSource/Enterprise list hovers keep working. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Experimental PR review
Greptile Summary
This PR unifies hover card styles across the home page by replacing the older
box-custom-hoverpseudo-element pattern withcorner-box-hover-stripes(diagonal stripe background on hover) and propagating the newhoverStripesprop throughCornerBoxusages inDeveloperTools,FeaturedCustomers, andIntegrations. Az-index: 20fix instyle.cssensures corner brackets remain visible above the stripe overlay on hover.Confidence Score: 4/5
Safe to merge; all changes are purely presentational with one minor transition-class conflict in chip-card.tsx.
No logic or data changes. One P2 finding in chip-card.tsx where conflicting Tailwind transition utilities could cause one animation to silently override the other, but it won't break any functionality.
components/ui/chip-card.tsx — conflicting transition utility classes
Important Files Changed
hoverStripesprop to threeCornerBoxcards — straightforward adoption of the unified hover style.hoverStripesprop to the outerCornerBox— no logic changes, clean update.corner-box-hover-stripesclasses directly to integration group divs that don't useCornerBox, consistent with the existing raw-div pattern in this file.box-custom-hoverwithcorner-box-hover-stripes transition-[background] duration-180 ease-out, but the resultingbaseClassNamenow contains two conflicting Tailwindtransition-*declarations.z-index: 20to.corner-box-corners--hover::beforeso corner brackets render above the stripe background on hover — intentional and correct.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[User hovers card] --> B{Component type} B -->|CornerBox with hoverStripes| C[corner-box-hover-stripes:hover\nstripe background applied] B -->|Raw div with class| D[corner-box-hover-stripes:hover\nstripe background applied] B -->|ChipCard| E[corner-box-hover-stripes:hover\nstripe background applied] C --> F[corner-box-corners--hover::before\nopacity 0→1, z-index 20\nCorner brackets appear] D --> G[No corner brackets\nStripe only] E --> H[corner-box-corners--hover\nCorner brackets + stripe]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "unify card styles" | Re-trigger Greptile