Skip to content

unify card styles#2886

Merged
felixkrrr merged 4 commits intomainfrom
LFE-9559-LFE-9559
Apr 30, 2026
Merged

unify card styles#2886
felixkrrr merged 4 commits intomainfrom
LFE-9559-LFE-9559

Conversation

@felixkrrr
Copy link
Copy Markdown
Contributor

@felixkrrr felixkrrr commented Apr 30, 2026

Disclaimer: Experimental PR review

Greptile Summary

This PR unifies hover card styles across the home page by replacing the older box-custom-hover pseudo-element pattern with corner-box-hover-stripes (diagonal stripe background on hover) and propagating the new hoverStripes prop through CornerBox usages in DeveloperTools, FeaturedCustomers, and Integrations. A z-index: 20 fix in style.css ensures corner brackets remain visible above the stripe overlay on hover.

Confidence Score: 4/5

Safe to merge; all changes are purely presentational with one minor transition-class conflict in chip-card.tsx.

No logic or data changes. One P2 finding in chip-card.tsx where conflicting Tailwind transition utilities could cause one animation to silently override the other, but it won't break any functionality.

components/ui/chip-card.tsx — conflicting transition utility classes

Important Files Changed

Filename Overview
components/home/DeveloperTools.tsx Adds hoverStripes prop to three CornerBox cards — straightforward adoption of the unified hover style.
components/home/FeaturedCustomers.tsx Adds hoverStripes prop to the outer CornerBox — no logic changes, clean update.
components/home/Integrations.tsx Applies corner-box-hover-stripes classes directly to integration group divs that don't use CornerBox, consistent with the existing raw-div pattern in this file.
components/ui/chip-card.tsx Replaces box-custom-hover with corner-box-hover-stripes transition-[background] duration-180 ease-out, but the resulting baseClassName now contains two conflicting Tailwind transition-* declarations.
style.css Adds z-index: 20 to .corner-box-corners--hover::before so corner brackets render above the stripe background on hover — intentional and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User hovers card] --> B{Component type}
    B -->|CornerBox with hoverStripes| C[corner-box-hover-stripes:hover\nstripe background applied]
    B -->|Raw div with class| D[corner-box-hover-stripes:hover\nstripe background applied]
    B -->|ChipCard| E[corner-box-hover-stripes:hover\nstripe background applied]
    C --> F[corner-box-corners--hover::before\nopacity 0→1, z-index 20\nCorner brackets appear]
    D --> G[No corner brackets\nStripe only]
    E --> H[corner-box-corners--hover\nCorner brackets + stripe]
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
components/ui/chip-card.tsx:66-73
**Conflicting `transition-*` utilities**

`transition-[background] duration-180 ease-out` and `transition-colors duration-120 cursor-pointer` both set `transition-property` on the same element. In Tailwind, only one wins in the generated stylesheet, so either the background-stripe animation (180ms) or the border/color transitions (120ms) will silently be dropped. Consider merging them into a single transition declaration or using a combined arbitrary value like `transition-[color,background-color,border-color,background] duration-150 ease-out` to cover all animated properties.

```suggestion
      "corner-box-hover-stripes transition-[color,background-color,border-color,background] duration-150 ease-out cursor-pointer",
      "relative group inline-flex items-center",
      "border border-line-structure bg-surface-bg rounded-[2px]",
```

Reviews (1): Last reviewed commit: "unify card styles" | Re-trigger Greptile

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-docs Ready Ready Preview, Comment Apr 30, 2026 7:56pm

Request Review

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 30, 2026
@github-actions
Copy link
Copy Markdown

@claude review

Comment thread components/ui/chip-card.tsx
Comment thread components/home/FeaturedCustomers.tsx
Comment thread style.css
…sion

- ChipCard baseClassName: drop legacy transition-colors duration-120 so
  tailwind-merge stops eating the new transition-[background] duration-180
  (both shared the transition + transition-duration conflict groups, and the
  later utilities were winning silently).
- FeaturedCustomers: scope the customer-name link group as group/story-link
  so adding hoverStripes (which adds an unnamed .group to the outer CornerBox)
  no longer triggers the underline when hovering anywhere else in the card.

Made-with: Cursor
Comment thread components/home/DeveloperTools.tsx
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 30, 2026
Use `group/box` instead of unnamed `group` on hoverStripes CornerBoxes so
nested `group-hover:` (e.g. secondary Button border) only reacts to its own
`button-wrapper` group, not card-wide hover.

Update BulletList and Link `text` variant with `group-hover/box:` where needed
so OpenSource/Enterprise list hovers keep working.

Made-with: Cursor
@felixkrrr felixkrrr added this pull request to the merge queue Apr 30, 2026
@dosubot dosubot Bot added the auto-merge This PR is set to be merged label Apr 30, 2026
Merged via the queue into main with commit a7173b5 Apr 30, 2026
13 checks passed
@felixkrrr felixkrrr deleted the LFE-9559-LFE-9559 branch April 30, 2026 19:58
@dosubot dosubot Bot removed the auto-merge This PR is set to be merged label Apr 30, 2026
Comment thread components/ui/button.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant