Skip to content

fix: Update styling of version label#2950

Merged
bezbac merged 1 commit into
mainfrom
feature/lfe-9785-fix-design-of-v3-label-of-self-hosted-docs
May 15, 2026
Merged

fix: Update styling of version label#2950
bezbac merged 1 commit into
mainfrom
feature/lfe-9785-fix-design-of-v3-label-of-self-hosted-docs

Conversation

@bezbac
Copy link
Copy Markdown
Member

@bezbac bezbac commented May 15, 2026

Greptile Summary

Updates the version label badge styling in DocBodyChrome.tsx to align with the project's design system, swapping the generic shadcn/ui token classes for project-specific tokens and a diagonal stripe background.

  • Replaces bg-secondary text-secondary-foreground rounded-md with border bg-stripe-pattern text-text-secondary, adopting the custom .bg-stripe-pattern utility (defined in style.css) and the Figma-sourced --color-text-secondary token.
  • Both bg-stripe-pattern and text-text-secondary are well-defined in the codebase; bg-stripe-pattern handles its own background shorthand so the border utility correctly inherits the global border-color from the * { @apply border-border; } reset.

Confidence Score: 5/5

Safe to merge — the change touches only CSS utility classes on a single decorative badge element, using tokens and classes already established in the design system.

Single-line class swap on a conditionally-rendered span. Both replacement classes (bg-stripe-pattern, text-text-secondary) are fully defined in style.css and carry correct light/dark mode values. No logic, props, or data flow is altered.

No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DocBodyChrome renders] --> B{withProse?}
    B -- No --> C[Return plain flex-1 div]
    B -- Yes --> D[Render DocsBody wrapper]
    D --> E{versionLabel != null AND != empty string?}
    E -- Yes --> F[span version badge: border + bg-stripe-pattern + text-text-secondary]
    E -- No --> G[Skip badge]
    F --> H[CopyMarkdownButton]
    G --> H
    H --> I{cookbook found?}
    I -- Yes --> J[NotebookBanner]
    I -- No --> K[children content]
    J --> K
Loading

Reviews (1): Last reviewed commit: "fix: Update styling of version label" | Re-trigger Greptile

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-docs Ready Ready Preview, Comment May 15, 2026 9:49am

Request Review

@github-actions
Copy link
Copy Markdown

@claude review

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. docs labels May 15, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple styling tweak.

Extended reasoning...

Overview

Single-line Tailwind class swap on the version label span in components/DocBodyChrome.tsx. Replaces rounded-md bg-secondary text-secondary-foreground with border bg-stripe-pattern text-text-secondary.

Security risks

None. Pure visual/CSS change.

Level of scrutiny

Minimal — cosmetic change in a docs site, no logic touched. The new utility classes (bg-stripe-pattern, text-text-secondary) are already used widely across the codebase.

Other factors

No reviewer comments, no bugs found by the hunter, change is self-contained.

@bezbac bezbac force-pushed the feature/lfe-9785-fix-design-of-v3-label-of-self-hosted-docs branch from 098753d to 4bd0cbc Compare May 15, 2026 09:46
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward CSS class swap on the version label badge.

Extended reasoning...

Overview

The PR changes the CSS utility classes on a single conditionally-rendered <span> in components/DocBodyChrome.tsx that displays an optional version label badge. It swaps rounded-md bg-secondary text-secondary-foreground for border bg-stripe-pattern text-text-secondary to align with the project's design system.

Security risks

None. This is a purely presentational change — no logic, props, data flow, or user input handling is modified.

Level of scrutiny

Very low. The change is a one-line, mechanical class swap on a decorative element. Both replacement utility classes (bg-stripe-pattern, text-text-secondary) are widely used across the codebase (50+ files) and defined in style.css.

Other factors

The PR is labeled size:XS and docs. No bugs were flagged by the bug hunting system. Vercel preview deployment is available for visual verification.

@bezbac bezbac added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 3666218 May 15, 2026
17 checks passed
@bezbac bezbac deleted the feature/lfe-9785-fix-design-of-v3-label-of-self-hosted-docs branch May 15, 2026 09:58
@dosubot dosubot Bot added the auto-merge This PR is set to be merged label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge This PR is set to be merged docs size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant