Improve Academy homepage entry paths and topic previews#2951
Open
annabellscha wants to merge 3 commits into
Open
Improve Academy homepage entry paths and topic previews#2951annabellscha wants to merge 3 commits into
annabellscha wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
…caping or encoding' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Greptile Summary
This PR reworks the Academy homepage by adding an above-the-fold intent split (two
Cardcomponents routing to the full loop or a specific topic) and upgradingLoopDiagramwith avariant="preview"mode that shows outcome-focused copy in each station card and a linked insight panel that updates on hover/focus.variant="preview"prop onLoopDiagramaddsoutcomeandinsightfields to each station, renders them inside the cards, and shows a linked preview panel below the diagram driven by the currently active (hovered/focused) station.content/academy/index.mdxremoves the old prose intro, inserts the two-card intent split, and switches to<LoopDiagram variant="preview" />.Confidence Score: 4/5
Safe to merge — changes are confined to a documentation UI component and an MDX page with no backend or data-flow impact.
The logic is straightforward and the new preview mode works correctly for the current data. Two small items worth tidying:
useLayoutEffectnow captures a render-derivedinnerHeightin a permanently-empty deps array (was harmless when it was a module constant), and.replace(" ", " ")only replaces the first newline in a title string.components/academy/LoopDiagram.tsx — the stale closure and replace calls are both there.
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[LoopDiagram rendered] --> B{variant prop} B -->|compact| C[Auto-cycle active station\nevery 1800ms] B -->|preview| D[No auto-cycle\nactive starts at 0] C --> E[Station cards with\ntitle + meta tags] D --> F[Station cards with\ntitle + outcome text] F --> G[Hover / Focus card\nsetActive i] G --> H[Preview panel below diagram\nshows insight for STATIONS active] H --> I[Link to STATIONS active .href] E --> J[Pulse dot highlights\nactive station]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "academy: clarify homepage entry paths" | Re-trigger Greptile