feat(api): update API spec from langfuse/langfuse 41f5847#812
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
wochinge
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR syncs the JavaScript SDK's generated API client against upstream Langfuse server commit
41f5847, introducing a newunstablenamespace withEvaluatorsandEvaluationRulesCRUD endpoints, aDELETEmethod forLlmConnections, new blob-storage export fields (exportSource,exportFieldGroups), and aCreateScoreSourcefield on the legacy score creation request.unstablenamespace — adds fully typed clients for evaluators and evaluation rules, each backed by a rich set of new domain types (EvaluationRule,Evaluator, filter/mapping types, structured error classes).ObservationV2field additions —modelIdis promoted to required, andinputPrice,outputPrice,totalPriceare added as new required fields;traceName,tags, andreleaseare added as optional denormalized trace fields.BlobStorageIntegrationupdates — new optionalexportSourceandexportFieldGroupsrequest/response fields, plus a newBlobStorageExportFieldGroupenum supportingtrace_context.Confidence Score: 3/5
Mergeable with caution — the new unstable endpoints have unreachable error-handling branches that could silently misdirect callers catching specific error types, and the
ObservationV2interface promotes previously optional fields to required.All new unstable client methods share a generated switch block that places legacy
LangfuseAPI.*Errorthrow statements under case labels already handled by theunstable.*Errorblock above them. Separately,ObservationV2.modelIdand three new price fields were made required, which is a TypeScript breaking change.packages/core/src/api/api/resources/unstable/resources/evaluators/client/Client.ts and evaluationRules/client/Client.ts — every method's error switch contains unreachable legacy error branches. packages/core/src/api/api/resources/commons/types/ObservationV2.ts — four fields changed from optional to required.
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile