Skip to content

Migrate additionalEnv to dedicated attributes for third parties components#73

Open
mautini wants to merge 5 commits into
langfuse:mainfrom
mautini:third_parties_values
Open

Migrate additionalEnv to dedicated attributes for third parties components#73
mautini wants to merge 5 commits into
langfuse:mainfrom
mautini:third_parties_values

Conversation

@mautini
Copy link
Copy Markdown
Contributor

@mautini mautini commented Feb 19, 2025

This MR changes the way the third parties components (minio, clickhouse, etc...) are configured. It remove the use of the additionalEnv property and move the configuration to dedicated properties in Values.yaml (langfuse.minio, langfuse.clickhouse etc...)


Important

Refactor third-party component configuration in Langfuse Helm chart to use dedicated properties in values.yaml, updating templates and adding secret management for external deployments.

  • Configuration Changes:
    • Refactor configuration of third-party components (MinIO, ClickHouse, etc.) from additionalEnv to dedicated properties in values.yaml.
    • Update values.yaml to include new properties for minio, clickhouse, valkey, and postgresql.
  • Template Updates:
    • Modify deployment-web.yaml and deployment-worker.yaml to use new configuration properties for environment variables.
    • Add secret templates clickhouse-secret.yaml and minio-secret.yaml for external deployments.
    • Update _helpers.tpl to define new helper functions for generating hostnames and secret names.
  • Miscellaneous:
    • Bump chart version in Chart.yaml from 0.12.1 to 0.13.0.
    • Minor formatting fix in README.md.

This description was created by Ellipsis for f7d92b5. It will automatically update as commits are pushed.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 19, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@mautini mautini changed the title Third parties values Migrate additionalEnv to dedicated attributes for third parties components Feb 19, 2025
Comment thread charts/langfuse/templates/_helpers.tpl
Comment thread charts/langfuse/templates/_helpers.tpl Outdated
@Steffen911 Steffen911 self-requested a review February 19, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants