Skip to content

Commit 06bbd30

Browse files
authored
fix(client): skip string serialization in attribute values (#1297)
* fix(client): skip string serialization in attribute values * push
1 parent 3d8ae65 commit 06bbd30

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

langfuse/_client/attributes.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,10 @@ def create_generation_attributes(
152152

153153

154154
def _serialize(obj: Any) -> Optional[str]:
155-
return json.dumps(obj, cls=EventSerializer) if obj is not None else None
155+
if obj is None or isinstance(obj, str):
156+
return obj
157+
158+
return json.dumps(obj, cls=EventSerializer)
156159

157160

158161
def _flatten_and_serialize_metadata(

tests/test_decorators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@ async def level_1_function(*args, **kwargs):
905905
assert generation.usage.output is not None
906906
assert generation.usage.total is not None
907907
print(generation)
908-
assert generation.output == "2"
908+
assert generation.output == 2
909909

910910

911911
def test_generator_as_function_input():

tests/test_openai.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test_openai_chat_completion_stream(openai):
119119
assert generation.data[0].usage.input is not None
120120
assert generation.data[0].usage.output is not None
121121
assert generation.data[0].usage.total is not None
122-
assert generation.data[0].output == "2"
122+
assert generation.data[0].output == 2
123123
assert generation.data[0].completion_start_time is not None
124124

125125
# Completion start time for time-to-first-token
@@ -179,7 +179,7 @@ def test_openai_chat_completion_stream_with_next_iteration(openai):
179179
assert generation.data[0].usage.input is not None
180180
assert generation.data[0].usage.output is not None
181181
assert generation.data[0].usage.total is not None
182-
assert generation.data[0].output == "2"
182+
assert generation.data[0].output == 2
183183
assert generation.data[0].completion_start_time is not None
184184

185185
# Completion start time for time-to-first-token

0 commit comments

Comments
 (0)