Skip to content

Commit 0b65df2

Browse files
committed
fix(tests): use direct dataset-item reads in e2e
1 parent fbac98e commit 0b65df2

File tree

1 file changed

+10
-25
lines changed

1 file changed

+10
-25
lines changed

tests/e2e/test_datasets.py

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,11 @@ def test_upsert_and_get_dataset_item():
9797
dataset_name=name, input=input, expected_output=input
9898
)
9999

100-
# Instead, get all dataset items and find the one with matching ID
101-
dataset = wait_for_result(
102-
lambda: langfuse.get_dataset(name),
103-
is_result_ready=lambda dataset: any(i.id == item.id for i in dataset.items),
100+
get_item = wait_for_result(
101+
lambda: langfuse.api.dataset_items.get(item.id),
102+
is_result_ready=lambda dataset_item: dataset_item.id == item.id,
104103
)
105-
get_item = None
106-
for i in dataset.items:
107-
if i.id == item.id:
108-
get_item = i
109-
break
110104

111-
assert get_item is not None
112105
assert get_item.input == input
113106
assert get_item.id == item.id
114107
assert get_item.expected_output == input
@@ -122,24 +115,16 @@ def test_upsert_and_get_dataset_item():
122115
status=DatasetStatus.ARCHIVED,
123116
)
124117

125-
# Refresh dataset and find updated item
126-
dataset = wait_for_result(
127-
lambda: langfuse.get_dataset(name),
128-
is_result_ready=lambda dataset: any(
129-
i.id == item.id
130-
and i.input == new_input
131-
and i.expected_output == new_input
132-
and i.status == DatasetStatus.ARCHIVED
133-
for i in dataset.items
118+
get_new_item = wait_for_result(
119+
lambda: langfuse.api.dataset_items.get(item.id),
120+
is_result_ready=lambda dataset_item: (
121+
dataset_item.id == item.id
122+
and dataset_item.input == new_input
123+
and dataset_item.expected_output == new_input
124+
and dataset_item.status == DatasetStatus.ARCHIVED
134125
),
135126
)
136-
get_new_item = None
137-
for i in dataset.items:
138-
if i.id == item.id:
139-
get_new_item = i
140-
break
141127

142-
assert get_new_item is not None
143128
assert get_new_item.input == new_input
144129
assert get_new_item.id == item.id
145130
assert get_new_item.expected_output == new_input

0 commit comments

Comments
 (0)