fix: skip trace url generation when tracing is disabled (#1503)

Author: jdidzik

langfuse/_client/client.py

@@ -2429,8 +2429,11 @@ def get_trace_url(self, *, trace_id: Optional[str] = None) -> Optional[str]:
             send_notification(f"Review needed for trace: {specific_trace_url}")
             ```
         """
-        project_id = self._get_project_id()
         final_trace_id = trace_id or self.get_current_trace_id()
+        if not final_trace_id:
+            return None
+
+        project_id = self._get_project_id()
 
         return (
             f"{self._base_url}/project/{project_id}/traces/{final_trace_id}"

tests/test_core_sdk.py

@@ -1976,6 +1976,19 @@ def test_generate_trace_id():
     assert trace_url == f"http://localhost:3000/project/{project_id}/traces/{trace_id}"
 
 
+def test_generate_trace_url_client_disabled():
+    langfuse = Langfuse(tracing_enabled=False)
+
+    with langfuse.start_as_current_span(
+        name="test-span",
+    ):
+        # The trace URL should be None because the client is disabled
+        trace_url = langfuse.get_trace_url()
+        assert trace_url is None
+
+    langfuse.flush()
+
+
 def test_start_as_current_observation_types():
     """Test creating different observation types using start_as_current_observation."""
     langfuse = Langfuse()