Skip to content

Commit 3405de0

Browse files
authored
fix(datasets): encoding (#993)
1 parent f5f6fe0 commit 3405de0

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

langfuse/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ def create_dataset(
481481
"""
482482
try:
483483
body = CreateDatasetRequest(
484-
name=self._url_encode(name), description=description, metadata=metadata
484+
name=name, description=description, metadata=metadata
485485
)
486486
self.log.debug(f"Creating datasets {body}")
487487
return self.client.datasets.create(request=body)
@@ -534,7 +534,7 @@ def create_dataset_item(
534534
"""
535535
try:
536536
body = CreateDatasetItemRequest(
537-
datasetName=self._url_encode(dataset_name),
537+
datasetName=dataset_name,
538538
input=input,
539539
expectedOutput=expected_output,
540540
metadata=metadata,

tests/test_datasets.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
def test_create_and_get_dataset():
1515
langfuse = Langfuse(debug=False)
1616

17-
name = create_uuid()
17+
name = "Text with spaces " + create_uuid()[:5]
1818
langfuse.create_dataset(name=name)
1919
dataset = langfuse.get_dataset(name)
2020
assert dataset.name == name
@@ -55,6 +55,7 @@ def test_create_dataset_item():
5555
)
5656

5757
dataset = langfuse.get_dataset(name)
58+
5859
assert len(dataset.items) == 3
5960
assert dataset.items[2].input == input
6061
assert dataset.items[2].expected_output is None

0 commit comments

Comments
 (0)