Skip to content

Commit 43e3059

Browse files
committed
fix(tests): align dataset e2e with archived item behavior
1 parent 0b65df2 commit 43e3059

1 file changed

Lines changed: 25 additions & 4 deletions

File tree

tests/e2e/test_datasets.py

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import time
22
from datetime import timedelta
33

4+
import pytest
5+
46
from langfuse import Langfuse
5-
from langfuse.api import DatasetStatus
7+
from langfuse.api import DatasetStatus, NotFoundError
68
from tests.support.utils import create_uuid, wait_for_result
79

810

@@ -112,7 +114,6 @@ def test_upsert_and_get_dataset_item():
112114
input=new_input,
113115
id=item.id,
114116
expected_output=new_input,
115-
status=DatasetStatus.ARCHIVED,
116117
)
117118

118119
get_new_item = wait_for_result(
@@ -121,14 +122,34 @@ def test_upsert_and_get_dataset_item():
121122
dataset_item.id == item.id
122123
and dataset_item.input == new_input
123124
and dataset_item.expected_output == new_input
124-
and dataset_item.status == DatasetStatus.ARCHIVED
125+
and dataset_item.status == DatasetStatus.ACTIVE
125126
),
126127
)
127128

128129
assert get_new_item.input == new_input
129130
assert get_new_item.id == item.id
130131
assert get_new_item.expected_output == new_input
131-
assert get_new_item.status == DatasetStatus.ARCHIVED
132+
assert get_new_item.status == DatasetStatus.ACTIVE
133+
134+
langfuse.create_dataset_item(
135+
dataset_name=name,
136+
input=new_input,
137+
id=item.id,
138+
expected_output=new_input,
139+
status=DatasetStatus.ARCHIVED,
140+
)
141+
142+
latest_dataset = wait_for_result(
143+
lambda: langfuse.get_dataset(name),
144+
is_result_ready=lambda dataset: all(
145+
dataset_item.id != item.id for dataset_item in dataset.items
146+
),
147+
)
148+
149+
assert all(dataset_item.id != item.id for dataset_item in latest_dataset.items)
150+
151+
with pytest.raises(NotFoundError):
152+
langfuse.api.dataset_items.get(item.id)
132153

133154

134155
def test_run_experiment():

0 commit comments

Comments
 (0)