Skip to content

Commit 4e1dafe

Browse files
committed
migrate tests
1 parent 6e89470 commit 4e1dafe

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

tests/test_error_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
import pytest
33

4-
from langfuse.utils.error_logging import (
4+
from langfuse._utils.error_logging import (
55
catch_and_log_errors,
66
auto_decorate_methods_with,
77
)

tests/test_error_parsing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
"""@private"""
22

3-
from langfuse.request import APIErrors, APIError
4-
from langfuse.parse_error import (
3+
from langfuse._utils.parse_error import (
54
generate_error_message,
65
generate_error_message_fern,
76
)
7+
from langfuse._utils.request import APIError, APIErrors
8+
from langfuse.api.core import ApiError
89
from langfuse.api.resources.commons.errors import (
910
AccessDeniedError,
1011
MethodNotAllowedError,
1112
NotFoundError,
1213
UnauthorizedError,
1314
)
14-
from langfuse.api.core import ApiError
1515
from langfuse.api.resources.health.errors import ServiceUnavailableError
1616

1717

tests/test_extract_model.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
OpenAI,
2525
)
2626

27-
from langfuse.callback import CallbackHandler
28-
from langfuse.extract_model import _extract_model_name
27+
from langfuse.langchain import CallbackHandler
28+
from langfuse.langchain.utils import _extract_model_name
2929
from tests.utils import get_api
3030

3131

@@ -134,20 +134,24 @@ def test_models(expected_model: str, model: Any):
134134
)
135135
def test_entire_llm_call(expected_model, model):
136136
callback = CallbackHandler()
137-
try:
138-
# LLM calls are failing, because of missing API keys etc.
139-
# However, we are still able to extract the model names beforehand.
140-
model.invoke("Hello, how are you?", config={"callbacks": [callback]})
141-
except Exception as e:
142-
print(e)
143-
pass
144137

145-
callback.flush()
138+
with callback.langfuse_client.start_as_current_span(name="parent") as span:
139+
trace_id = span.trace_id
140+
141+
try:
142+
# LLM calls are failing, because of missing API keys etc.
143+
# However, we are still able to extract the model names beforehand.
144+
model.invoke("Hello, how are you?", config={"callbacks": [callback]})
145+
except Exception as e:
146+
print(e)
147+
pass
148+
149+
callback.langfuse_client.flush()
146150
api = get_api()
147151

148-
trace = api.trace.get(callback.get_trace_id())
152+
trace = api.trace.get(trace_id)
149153

150-
assert len(trace.observations) == 1
154+
assert len(trace.observations) == 2
151155

152156
generation = list(filter(lambda o: o.type == "GENERATION", trace.observations))[0]
153157
assert generation.model == expected_model

0 commit comments

Comments
 (0)